From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sat, 15 Jul 2023 18:53:19 -0400 Message-ID: References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> <83jzv1b152.fsf@gnu.org> <83a5vxas9k.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25855"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 00:54:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKo9g-0006Zt-Il for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 00:54:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKo9L-0006HS-7t; Sat, 15 Jul 2023 18:54:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKo9K-0006HG-Bf for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 18:54:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKo9K-0003KJ-3y for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 18:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKo9J-00011i-OR for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 18:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 22:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.16894616133905 (code B ref 64596); Sat, 15 Jul 2023 22:54:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 15 Jul 2023 22:53:33 +0000 Original-Received: from localhost ([127.0.0.1]:46240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKo8q-00010u-Lx for submit@debbugs.gnu.org; Sat, 15 Jul 2023 18:53:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKo8l-00010d-Gt for 64596@debbugs.gnu.org; Sat, 15 Jul 2023 18:53:31 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DE8E380065; Sat, 15 Jul 2023 18:53:21 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D53F6801B3; Sat, 15 Jul 2023 18:53:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689461600; bh=SxdmDD+vgzHQ86JcdkDNX5BMMkJIc/tcKWHbNYQxgSE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jAxghVCYI2vKX5wtKJIz8k6WZCwTX9/09nNTQDM2njp01cRLUM7jMWthSG5z5bIvY zLlbnjDT4QRGGW1bOsxgLD6heqz+UcRdtPR/eGsA9QAfRaxVBhuDGtDYxL2/7sxPxQ vBtTxPPFjmAoUomWY2RVSytm+l1z+354IwALQ1otlLnDTQrLl7H2mKwhr2L5jS+PUu bBKTdd4X3DvAm37pisjmHDRCwi6ibDMHepqsBNyDcPuF/Hg4pR8oEllcV3J1qI+T33 CtRV7MK3x3AvTqR27TjnmptApJbQiTcy4ptkTDyB+AR1rarbxaTDvvTtD9rcLFGlnY ghZJTVeu0FG6g== Original-Received: from pastel (unknown [104.247.238.169]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id ABA721201FF; Sat, 15 Jul 2023 18:53:20 -0400 (EDT) In-Reply-To: <83a5vxas9k.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jul 2023 22:28:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265253 Archived-At: >> Sorry, I skipped this part in my previous email. >> I understand the above code, but I'm not sure what explanation might >> be needed so you can understand it as well. Maybe the problem is the >> name `consider_all_windows_p` which suggests that all windows will be >> updated, but it only says that we should loop through all the windows to >> try and find those which need to be updated. > > The actual issue with the above is different: it implies that > update_mode_lines _always_ indicates that more than a single mode line > should be updated (which is why we need to "consider all windows"). How 'bout the wording below, then? Stefan diff --git a/src/xdisp.c b/src/xdisp.c index a3464c2c375..13f4fbca074 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -16490,8 +16490,10 @@ redisplay_internal (void) enum {MAX_GARBAGED_FRAME_RETRIES = 2 }; int garbaged_frame_retries = 0; - /* True means redisplay has to consider all windows on all - frames. False, only selected_window is considered. */ + /* False, means that only the selected_window needs to be updated. + True means that other windows may need to be updated as well, + so we need to consult the `redisplay` bits of + all windows/buffer/frames. */ bool consider_all_windows_p; /* True means redisplay has to redisplay the miniwindow. */