From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/org ee0961ba31: lisp/org-table.el: fix warning about `eq' usage Date: Tue, 31 Oct 2023 23:05:02 -0400 Message-ID: References: <169879312007.20093.7465071871654518215@vcs2.savannah.gnu.org> <20231031225840.6A0FEC06553@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12939"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Karl Fogel To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 01 04:06:02 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qy1YP-00037o-Vu for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Nov 2023 04:06:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qy1XZ-00032J-Vb; Tue, 31 Oct 2023 23:05:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qy1XY-00032B-Md for emacs-devel@gnu.org; Tue, 31 Oct 2023 23:05:08 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qy1XW-0005Qi-LE for emacs-devel@gnu.org; Tue, 31 Oct 2023 23:05:08 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1C4ED80667; Tue, 31 Oct 2023 23:05:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1698807904; bh=rcAEHh7qsl6Gq/RN3OsMoVXtzctDswb6eX/1TX2iA78=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AH2ygASRvvlIqJCEK3VDXnOjvCQpKP+9+AnWfB7ylCMx3ViBB/SPiYJjVCbPaPrxO DZ4dfXmUphwXtkpzEZ28Cg7NneObCXxL60lfvnf3l4fDa0NfW96JzJVRvFVxNBV68I JaxJCz83wwKjhT5Vku0++d6EQsgSf4VCz5bRPu+aWLFzx2ehwq4B3E5azA47+bdwZp BZuE4KgjHUx5gAT9EzorY2dzC87sdnJW8XSW/M7POqklvPDK8Y0d64Q4EiGWKZLBRb SrthOTt4VTlMEQoyjq6ViBSfHd9mfdYnHE2Z27aR6oqhp7sNUZpcg1b2nBBAo5xSpd 5laPainWDJSAg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 46329802BB; Tue, 31 Oct 2023 23:05:04 -0400 (EDT) Original-Received: from pastel (unknown [45.72.195.71]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1EAFE120281; Tue, 31 Oct 2023 23:05:04 -0400 (EDT) In-Reply-To: <20231031225840.6A0FEC06553@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Tue, 31 Oct 2023 18:58:40 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312037 Archived-At: > This change does not affect the behavior of `org-table-make-reference' > because `eq' treats all instances of the empty string as the same > object anyway, e.g., `(eq (string-trim "aaabbb" "a+" "b+") "")' ==> t. Not quite so: (eq (string-to-multibyte "") "") => nil -- Stefan