From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs,gmane.emacs.orgmode Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Tue, 09 Jan 2024 11:01:24 -0500 Message-ID: References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> <875y02y0da.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6838"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65734@debbugs.gnu.org, Eli Zaretskii , emacs-orgmode@gnu.org, Max Nikulin , iota@whxvd.name To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 17:02:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNEYV-0001Vl-OL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 17:02:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNEY9-0002N0-2s; Tue, 09 Jan 2024 11:01:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNEY7-0002Mb-C2 for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 11:01:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNEY7-0003Oc-2i for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 11:01:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNEYD-0005sd-Mq for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 11:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 16:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.170481610522575 (code B ref 65734); Tue, 09 Jan 2024 16:02:01 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 9 Jan 2024 16:01:45 +0000 Original-Received: from localhost ([127.0.0.1]:40707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNEXw-0005s3-UW for submit@debbugs.gnu.org; Tue, 09 Jan 2024 11:01:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNEXs-0005rl-Cf for 65734@debbugs.gnu.org; Tue, 09 Jan 2024 11:01:43 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 96743100068; Tue, 9 Jan 2024 11:01:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1704816086; bh=v8Cu8hji29G32K+i2NCVQKswRVUUdDK8WHwDD1yDpsY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=d203HkjCEwOiEC/IqKB17MPKKawQuMgW7FAJZ4vxRJfp5AG3cMPyBIMv/dTuXJUzp oXNopO21F4zm6fvAmny6RKo5pf7Xepy6UcscU0GoatvJJ7b5VEd8i+o6sjdU2yevIx 7S5y092RAgVYeP51K+fiBIL0jGw/JG4Oe65+hL2BcIdPeRHlnBfwCFH01GQWDYtlb9 fcRg55MGe/T1CNTGuL85v47E6P3aY6DinmgG6Y/Id4ktzqxg2Vv1Nv6oiGUjKO/6pR 6645U1YgnVbTDwgPmDYdnR6PgKIUrkhjRDkR5m77KoRGDO22F64G8+qM6T0DkZc9Vf cskzChHm/gayw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4BDB510004C; Tue, 9 Jan 2024 11:01:26 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 09A02120BBA; Tue, 9 Jan 2024 11:01:26 -0500 (EST) In-Reply-To: <875y02y0da.fsf@localhost> (Ihor Radchenko's message of "Tue, 09 Jan 2024 15:47:45 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277634 gmane.emacs.orgmode:158940 Archived-At: >>> But in addition to that, I suspect that Org should probably not modify >>> visibility directly from the modification hooks. Instead, its >>> modification hook function should just stash the info somewhere and then >>> update the visibility later on, such as in a `post-command-hook`, timer, >>> `pre-redisplay-functions`, younameit. >> Good idea. At least, for this specific feature in Org mode. > Now, done. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f9702a09e Great, thanks! > Although, I am still interested to pursue feature request to allow > customizing `kill-whole-line' and `kill-line' by major modes. [ I'm sorry I didn't pay very much attention to this part. Naively, I'd suggest you use `remap` bindings for that, but I'm sure you're aware of that option, so you presumably have good reasons to want something else. ] Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4M5DIRpunWWlsgAAkFu2QA (envelope-from ) for ; Tue, 09 Jan 2024 17:02:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 0NMkHhpunWVddAEAqHPOHw (envelope-from ) for ; Tue, 09 Jan 2024 17:02:34 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=d203HkjC; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704816154; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=z5eeJsXZOv0orrjLImZOfvb2PveY3Jq1BA3wUKNudZw=; b=E2vAal+XahTm4/DVdbDvuq0YvwEoeSXj7zxdvRwR3QVNJPDgGEJgbKomGeb8wKLDwqSg/d nXCI39WfoEy4F9V4wr+x4f5teM1TSToKsc4kyFMX/Ol0+5zlwJTQ0b6ll7dlRA1d0gOfM8 N7DCR43sma3I3kWqZ/tIXxPekT9iFZshafyAEC9hjORKdamR99T7rdI96fviODvfzolP7Y G09nm2pUfju1TBByNKjoIEXtd2/BiM7ZSre3UJdjc8fGUxjELnGzirQCPd0Z+Qdt/rTX7L 4GSbPuoO/mkuZkZuH4FeVoyPEMwfMpu/+jMYdBI+uhsPGTCMAXwDdYc5YV+0bQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704816154; a=rsa-sha256; cv=none; b=bOYganf13H7tqptNxDXDHVez6ydndFUsHlPDe/YUksojIoD3Gcp03PbqkVkCWRJ1Fpcao3 KLFjAO6DqMb/dqmAujyiOpJy9xOkajo1GjVq27++bz5NuboCIZ1X+3O3n5tfD5LIYVcZrT R5g++mYmBsgoo47HjepL/2/d+EHM6D9MQbSW1h4ZWi7cAOc6qZWiND7kua8T2xmK3CsLGr 6H2MQPdMMiDU93/a81CJxXvE0EpV7T6oHeYxkWTi2/852OC+pWIGQUsIexs4X9OL4UuIDz hHm/FOsLAnnKHUVrUUCqBmbUuW7mZGuNqpnDzwjaE5SKtNGdadnrDECSZhMj+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=d203HkjC; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 44AFB67971 for ; Tue, 9 Jan 2024 17:02:34 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNEXx-0002Ik-A2; Tue, 09 Jan 2024 11:01:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNEXr-0002IG-2n for emacs-orgmode@gnu.org; Tue, 09 Jan 2024 11:01:39 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNEXl-0003CF-Qi; Tue, 09 Jan 2024 11:01:37 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 96743100068; Tue, 9 Jan 2024 11:01:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1704816086; bh=v8Cu8hji29G32K+i2NCVQKswRVUUdDK8WHwDD1yDpsY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=d203HkjCEwOiEC/IqKB17MPKKawQuMgW7FAJZ4vxRJfp5AG3cMPyBIMv/dTuXJUzp oXNopO21F4zm6fvAmny6RKo5pf7Xepy6UcscU0GoatvJJ7b5VEd8i+o6sjdU2yevIx 7S5y092RAgVYeP51K+fiBIL0jGw/JG4Oe65+hL2BcIdPeRHlnBfwCFH01GQWDYtlb9 fcRg55MGe/T1CNTGuL85v47E6P3aY6DinmgG6Y/Id4ktzqxg2Vv1Nv6oiGUjKO/6pR 6645U1YgnVbTDwgPmDYdnR6PgKIUrkhjRDkR5m77KoRGDO22F64G8+qM6T0DkZc9Vf cskzChHm/gayw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4BDB510004C; Tue, 9 Jan 2024 11:01:26 -0500 (EST) Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 09A02120BBA; Tue, 9 Jan 2024 11:01:26 -0500 (EST) From: Stefan Monnier To: Ihor Radchenko Cc: emacs-orgmode@gnu.org, Eli Zaretskii , 65734@debbugs.gnu.org, Max Nikulin , iota@whxvd.name Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <875y02y0da.fsf@localhost> (Ihor Radchenko's message of "Tue, 09 Jan 2024 15:47:45 +0000") Message-ID: References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> <875y02y0da.fsf@localhost> Date: Tue, 09 Jan 2024 11:01:24 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -10.31 X-Spam-Score: -10.31 X-Migadu-Queue-Id: 44AFB67971 X-Migadu-Scanner: mx12.migadu.com X-TUID: JZsyv9midv4e >>> But in addition to that, I suspect that Org should probably not modify >>> visibility directly from the modification hooks. Instead, its >>> modification hook function should just stash the info somewhere and then >>> update the visibility later on, such as in a `post-command-hook`, timer, >>> `pre-redisplay-functions`, younameit. >> Good idea. At least, for this specific feature in Org mode. > Now, done. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f9702a09e Great, thanks! > Although, I am still interested to pursue feature request to allow > customizing `kill-whole-line' and `kill-line' by major modes. [ I'm sorry I didn't pay very much attention to this part. Naively, I'd suggest you use `remap` bindings for that, but I'm sure you're aware of that option, so you presumably have good reasons to want something else. ] Stefan