From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70105: 30.0.50; Emacs should support EditorConfig out of the box Date: Tue, 18 Jun 2024 09:17:03 -0400 Message-ID: References: <867chibhqi.fsf@gnu.org> <86frtnd2e6.fsf@gnu.org> <87bk3yai02.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38163"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: jcs090218@gmail.com, bjorn.bidar@thaodan.de, Eli Zaretskii , 8slashes+git@gmail.com, 70105@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 18 15:18:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJYjC-0009fg-CF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Jun 2024 15:18:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJYim-0006Mt-Nt; Tue, 18 Jun 2024 09:18:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJYil-0006Mc-KI for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2024 09:17:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJYil-0002gv-DY for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2024 09:17:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJYin-0002jA-OZ for bug-gnu-emacs@gnu.org; Tue, 18 Jun 2024 09:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jun 2024 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70105 X-GNU-PR-Package: emacs Original-Received: via spool by 70105-submit@debbugs.gnu.org id=B70105.171871663710426 (code B ref 70105); Tue, 18 Jun 2024 13:18:01 +0000 Original-Received: (at 70105) by debbugs.gnu.org; 18 Jun 2024 13:17:17 +0000 Original-Received: from localhost ([127.0.0.1]:42228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJYi4-0002i6-MI for submit@debbugs.gnu.org; Tue, 18 Jun 2024 09:17:16 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJYi1-0002ht-TQ for 70105@debbugs.gnu.org; Tue, 18 Jun 2024 09:17:15 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B8A84441640; Tue, 18 Jun 2024 09:17:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1718716624; bh=NWNvIGWjYg8d/EXhT1GCcDRFTwZvgmxc4ce48AK0JII=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iRYPAlbLJxxCmhUOnHNz8ZE6FcrUPzow6RSCH6pJAE876O85umK61LKgNvZIFQTmN nI+S3B2gW/YUI55j5xZtDK5Mbu9BJoGZYwevjStB7MERKta9ynQ/6mi40UTyUvWORp FLgKSXMTP8pPH7vpDzgFZ8Z/VTo4wZOYyUuFtYG1rx/+oOMVbwP9X3GiGCgtyVjN7A Pq6gCFn+dWpuz22cFbiHogMPcJlb6NzKoyZau9Dzc9Ra5bj74wWPyvXx6ZqqJtDhkf 0ryb8ON7wuP11vMFa1DHaatTLntQrF5Ouy4cJWOG4+2/SBu0BkBRbBhkZkTS6Ml8fp YbltxLJDG8NHQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3D22D441606; Tue, 18 Jun 2024 09:17:04 -0400 (EDT) Original-Received: from pastel (unknown [24.140.236.196]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 023301203FF; Tue, 18 Jun 2024 09:17:03 -0400 (EDT) In-Reply-To: <87bk3yai02.fsf@localhost> (Ihor Radchenko's message of "Tue, 18 Jun 2024 06:21:17 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287438 Archived-At: >> I pushed to the branch `scratch/emacs-editorconfig` a bunch of patches >> which add a few `lisp/editorconfig*.el` files. >> The main effect is to define a new (global) minor mode >> `editorconfig-mode` (I assumed we'll keep it disabled by default in >> Emacs-30, but I think it would make sense to enable by default in >> Emacs-31 (i.e. on `master` after the branch is cut)) as well as a new >> major mode `editorconfig-conf-mode` to edit `.editorconfig` files. > Is it possible for major modes to indicate that [*] editorconfig setting > must not be used? In the upstream package, yes, but I have not included that part currently in the code I submit to Emacs. > In particular, Org mode needs to use a fixed `tab-width' and > editorconfig must not override that (it is a part of the syntax). I don't understand: `tab-width` mostly affects the display, how can it break Org mode? In any case, Org is not the only mode with such needs (Makefile, Haskell, Python, come to mind). But also, disabling editorconfig wholesale seems a bit crude. Maybe we'll need a more targeted way to address the problem (and there's always `hack-local-variables-hook`). > We already had a user reporting problems caused by > https://github.com/editorconfig/editorconfig-emacs where tab-width was > changed to 4 by default. The upstream code sets `tab-width` in more cases than the code I'm submitting, so maybe I already fixed the problem? Do you have a more precise URL for the issue? Stefan