all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: enometh@meer.net, 74132@debbugs.gnu.org
Subject: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
Date: Sat, 09 Nov 2024 11:59:44 -0500	[thread overview]
Message-ID: <jwvwmhcxs9k.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <864j4gmkou.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Nov 2024 18:33:05 +0200")

>> > What will this do to URLs such as
>> >   http://web.archive.org/web/20240221082647/https://www.imdb.com/
>> Depends where point is: if it's after the `https`, then you get the
>> "sub-URL" and if it's on or before the `https` then you get the whole URL.
> Exactly.  This could be considered a bug, because the actual URL is
> the entire thing.

We could refine our heuristic to as to keep looking backward when the
apparent beginning of the URL is immediately preceded by a /, of course,
but I'm not sure it's worth the trouble.

AFAICT any behavior we come up with will have such cases.

>> > I'm not sure I see how to resolve this dilemma.  Stefan, any ideas?
>> "url at point" is inherently heuristic, so I'm not too worried.
>> But I do very much agree with Stefan that we need tests, because it's
>> all too easy to run around in circles otherwise, fixing the heuristic to
>> handle case A but breaking case B along the way.
> I'm okay with adding tests, of course, but I'm not sure which of the
> two behaviors leave you "not too worried": the current or the new one
> after the proposed change.  And why.

The [...](...) case mentioned by Madhu is a fairly common one IME, so
I'm in favor of fixing it.  As for the behavior in your example, to the
extent that the users can control which URL they get (depending on where
they place point (or click)), I'm OK with either behavior.


        Stefan






  reply	other threads:[~2024-11-09 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 10:36 bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown Madhu
     [not found] ` <handler.74132.B.173037135112690.ack@debbugs.gnu.org>
2024-11-01  5:38   ` bug#74132: Acknowledgement (31.0.50; thing-at-pt, ffap and Github markdown) Madhu
2024-11-02 22:04     ` Stefan Kangas
2024-11-09 10:29 ` bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown Eli Zaretskii
2024-11-09 15:52   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-09 16:33     ` Eli Zaretskii
2024-11-09 16:59       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-11-09 17:59         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvwmhcxs9k.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=74132@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=enometh@meer.net \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.