From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: find-file-noselect needs save-match-data Date: Fri, 15 Jun 2007 10:23:52 -0400 Message-ID: References: <46665AD7.7040706@gmx.at> <87k5ueq23m.fsf@kfs-lx.testafd.dk> <87myz8c10t.fsf@jurta.org> <18030.3441.204697.244518@rgrjr.dyndns.org> <87zm3515r4.fsf@jurta.org> <85k5u8x2gm.fsf@lola.goethe.zz> <87r6og6czf.fsf@catnip.gol.com> <85bqfkx0i5.fsf@lola.goethe.zz> <4670E6C3.7070505@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1181921689 8365 80.91.229.12 (15 Jun 2007 15:34:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 15 Jun 2007 15:34:49 +0000 (UTC) Cc: miles.bader@necel.com, schwab@suse.de, emacs-devel@gnu.org, juri@jurta.org, martin rudalics , miles@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 15 17:34:46 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HzDow-0000xF-6G for ged-emacs-devel@m.gmane.org; Fri, 15 Jun 2007 17:34:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HzDov-0000TA-Pp for ged-emacs-devel@m.gmane.org; Fri, 15 Jun 2007 11:34:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HzDos-0000Sv-Mz for emacs-devel@gnu.org; Fri, 15 Jun 2007 11:34:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HzDoq-0000Sj-AP for emacs-devel@gnu.org; Fri, 15 Jun 2007 11:34:37 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HzDoq-0000Sg-5H for emacs-devel@gnu.org; Fri, 15 Jun 2007 11:34:36 -0400 Original-Received: from tomts16.bellnexxia.net ([209.226.175.4] helo=tomts16-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HzDol-0007lO-SY; Fri, 15 Jun 2007 11:34:32 -0400 Original-Received: from pastel.home ([70.55.143.156]) by tomts16-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070615142352.THWL1673.tomts16-srv.bellnexxia.net@pastel.home>; Fri, 15 Jun 2007 10:23:52 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2210A8042; Fri, 15 Jun 2007 10:23:51 -0400 (EDT) In-Reply-To: (Richard Stallman's message of "Fri\, 15 Jun 2007 04\:48\:24 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-detected-kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72961 Archived-At: > Yes, I proposed to add `save-match-data' to a variety of file handling > functions at the outermost level. The main reason for my proposal was > to introduce some sort of consistency among functions in files.el with > respect to saving match-data. > I think that the file-manipulation functions that seem clean and > abstract ought to call `save-match-data'. find-file-noselect is a huge function which runs major modes, looks for file-local variables, looks for other buffers already visiting the file, checks the buffer if it is still uptodate w.r.t the file, ... It's nowhere near "clean and abstract". Anybody who expects such a large function to preserve the match-data will basically expect *every* function to preserve the match-data. Stefan