From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: Emacs-Devel <emacs-devel@gnu.org>
Subject: Re: toggling a minor mode should not tell Customize that the value has been set
Date: Sat, 05 Jan 2008 21:14:25 -0500 [thread overview]
Message-ID: <jwvve677lk4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <DHEEKFAFJEFOJHLCFPFDAEGACDAA.drew.adams@oracle.com> (Drew Adams's message of "Sat, 5 Jan 2008 09:48:47 -0800")
> `define-minor-mode' adds this code to the definition of every minor mode:
> (if (called-interactively-p)
> (progn
> ,(if globalp `(customize-mark-as-set ',mode)) ; <=== WHY?
Because M-x foo-mode RET on such global minor-modes isn't much different
from M-x customize-variable RET foo-mode RET .... -> Set for current session.
> What was the rationale behind this behavior? Why should toggling
The rationale is that Custom does not like it when Elisp code modifies
a defcustom behind its back.
If we don't do it, then Custom will simply tell you that the variable
was set outside of Custom and that saving the var may hence not have
the expected effect.
> A user should be able to use `customize-customized' (including perhaps in
> `kill-emacs-query-functions') to see what s?he has customized and might want
> to save.
Exactly, after trying our M-x iswtchb-mode RET she may very much like to
see that iswitchb-mode is now eabled and that she could save it so that
it's enabled next time around.
Stefan
next prev parent reply other threads:[~2008-01-06 2:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 17:48 toggling a minor mode should not tell Customize that the value has been set Drew Adams
2008-01-06 2:14 ` Stefan Monnier [this message]
2008-01-06 8:01 ` Drew Adams
2008-01-06 16:16 ` Stefan Monnier
2008-01-06 20:47 ` Drew Adams
2008-01-06 21:20 ` Stefan Monnier
2008-01-06 23:00 ` Drew Adams
2008-01-07 1:32 ` Stefan Monnier
2008-01-06 22:41 ` martin rudalics
2008-01-06 23:41 ` Drew Adams
2008-01-07 1:26 ` Stefan Monnier
2008-01-07 7:34 ` martin rudalics
2008-01-07 11:31 ` Richard Stallman
2008-01-06 10:46 ` Richard Stallman
2008-01-06 16:19 ` toggling a minor mode should not tell Customize that the value hasbeen set Drew Adams
2008-01-07 17:15 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvve677lk4.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.