set-face-attribute :height gacks on floating-point

set-face-attribute :height gacks on floating-point

[Eric Hanchrow]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I typed

        M-: (set-face-attribute 'default nil :height 1.1) RET

and saw an error:

        set-face-attribute: Invalid face height: 1.1

However, the documentation for set-face-attribute says:

    `:height'

    VALUE must be either an integer specifying the height of the font to use
    in 1/10 pt, a floating point number specifying the amount by which to
    scale any underlying face, or a function, which is called with the old
    height (from the underlying face), and should return the new height.

... so I expected my current font to get 10% bigger.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/src/emacs-via-git/etc/DEBUG for instructions.


In GNU Emacs 23.0.0.1 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
 of 2008-03-08 on enver-laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--enable-maintainer-mode' '--with-xpm=no' '--with-jpeg=no' '--with-gif=no' '--with-tiff=no' '--with-xft' '--with-gtk' '--enable-font-backend''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Help

Minor modes in effect:
  erc-autojoin-mode: t
  erc-match-mode: t
  erc-log-mode: t
  erc-services-mode: t
  desktop-save-mode: t
  recentf-mode: t
  display-time-mode: t
  global-auto-revert-mode: t
  shell-dirtrack-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
  view-mode: t

Recent input:
s e d - f o n t s C-a C-M-q C-n C-e M-b C-M-k M-( * 
SPC r a t M-/ SPC 1 . 0 C-a <tab> C-M-x C-x C-s C-- 
C-- C-- C-+ C-+ C-+ C-+ C-+ C-+ C-- C-- C-p C-e C-x 
C-e C-M-p M-1 M-( o r SPC t SPC C-M-x C-- C-+ C-+ C-n 
C-h f <return> C-x o C-s C-h e i g h t C-x o C-h v 
<return> C-h f <return> C-x o C-s C-s C-a C-s h e i 
g h t C-a M-0 C-l C-n C-n C-n C-x o C-e M-b M-b C-M-u 
M-1 M-( l a m b d a M-( o l d C-f C-f C-f C-f C-f C-M-f 
C-M-k SPC o l d C-M-a C-M-q C-M-x C-- C-n C-n C-M-d 
C-x F <return> C-x 1 C-x n d C-x b <return> C-x C-s 
C-x v = C-x 1 C-v C-v C-p C-p C-x C-q C-c C-r p C-c 
C-a C-x o C-x C-s C-x v = C-x 1 C-v C-x k <return> 
C-M-e C-M-e C-u C-u C-n C-p C-e C-x C-e C-M-p C-M-SPC 
M-w M-: C-y M-b C-f C-d 6 <return> M-: M-p C-e M-b 
C-f M-d . 1 <return> C-x b <return> C-x n d C-s : h 
e C-w C-s C-s C-M-v C-v C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-u C-n C-n C-x n w C-M-d C-x F <return> 
C-x n d C-s h e i g h t C-n C-a C-p C-n C-M-SPC C-p 
C-x n n C-g C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-p C-x n w C-x b C-s C-s <return> 
C-p C-SPC C-u C-n C-x C-x C-p C-p M-< M-w M-x r e p 
o <tab> r <tab> <return>

Recent messages:
call-interactively: There is no other window
Mark set
Mark saved where search started
Mark set
Quit
Mark set
Saved text until "ace), and should return the new height.
"
Making completion list...
Loading emacsbug...done

-- 
People studying literature rarely say anything that would be of the
slightest use to those producing it.
        -- Paul Graham

Re: set-face-attribute :height gacks on floating-point

[Stefan Monnier]

> In GNU Emacs 23.0.0.1 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
>  of 2008-03-08 on enver-laptop

What version is that?
Can you try to use a recent checkout of the trunk instead?


        Stefan

Re: set-face-attribute :height gacks on floating-point

[Eric Hanchrow]

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

    Stefan> What version is that?  

That's the unicode-xft branch, gotten from
git://git.sv.gnu.org/emacs.git with "git checkout unicode-xft"
                                   
    Stefan> Can you try to use a recent checkout of the trunk instead?

Same behavior.

-- 
Most people don't even know what a rootkit is, so why should they
care about it?
        -- Thomas Hesse, Sony BMG's president of global digital business

Re: set-face-attribute :height gacks on floating-point

[Miles Bader]

Eric Hanchrow <offby1@blarg.net> writes:
>     Stefan> What version is that?  
>
> That's the unicode-xft branch, gotten from
> git://git.sv.gnu.org/emacs.git with "git checkout unicode-xft"

That branch is very out-of-date -- I used to merge to it, but I haven't
in a long time (it wasn't clear that it had any future).

-Miles

-- 
Bigot, n. One who is obstinately and zealously attached to an opinion that
you do not entertain.

RE: set-face-attribute :height gacks on floating-point

[Drew Adams]

> >     Stefan> What version is that?  
> >
> > That's the unicode-xft branch, gotten from
> > git://git.sv.gnu.org/emacs.git with "git checkout unicode-xft"
> 
> That branch is very out-of-date -- I used to merge to it, but 
> I haven't in a long time (it wasn't clear that it had any future).

FWIW, I see the same thing in Emacs 22.1 (release):

In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
 of 2007-06-02 on RELEASE
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'

Re: set-face-attribute :height gacks on floating-point

[Jan Djärv]

Miles Bader skrev:
> Eric Hanchrow <offby1@blarg.net> writes:
>>     Stefan> What version is that?  
>>
>> That's the unicode-xft branch, gotten from
>> git://git.sv.gnu.org/emacs.git with "git checkout unicode-xft"
> 
> That branch is very out-of-date -- I used to merge to it, but I haven't
> in a long time (it wasn't clear that it had any future).
> 

It should be removed, can anybody with CVS access do that?  Do we have any 
policy for removing branches?

	Jan D.

Re: set-face-attribute :height gacks on floating-point

[Miles Bader]

Jan Djärv <jan.h.d@swipnet.se> writes:
>>> That's the unicode-xft branch, gotten from
>>> git://git.sv.gnu.org/emacs.git with "git checkout unicode-xft"
>>
>> That branch is very out-of-date -- I used to merge to it, but I haven't
>> in a long time (it wasn't clear that it had any future).
>
> It should be removed, can anybody with CVS access do that?  Do we have
> any policy for removing branches?

Dunno, but don't do it immediately -- I wanna do a diff against its last
merge base, as I remember there were some random cleanups in there that
should probably just go into the trunk (nothing major though).

-Miles

-- 
Selfish, adj. Devoid of consideration for the selfishness of others.

Re: set-face-attribute :height gacks on floating-point

[Stefan Monnier]

Stefan> What version is that?  
>>> 
>>> That's the unicode-xft branch, gotten from
>>> git://git.sv.gnu.org/emacs.git with "git checkout unicode-xft"
>> 
>> That branch is very out-of-date -- I used to merge to it, but I haven't
>> in a long time (it wasn't clear that it had any future).
>> 

> It should be removed, can anybody with CVS access do that?  Do we have any
> policy for removing branches?

It's usually better to keep those things around.  We could change it
in the same way we changed the unicode branch, so people are aware
they're using an obsolete branch.


        Stefan

Re: set-face-attribute :height gacks on floating-point

[Jan Djärv]

Stefan Monnier skrev:
> Stefan> What version is that?  
>>>> That's the unicode-xft branch, gotten from
>>>> git://git.sv.gnu.org/emacs.git with "git checkout unicode-xft"
>>> That branch is very out-of-date -- I used to merge to it, but I haven't
>>> in a long time (it wasn't clear that it had any future).
>>>
> 
>> It should be removed, can anybody with CVS access do that?  Do we have any
>> policy for removing branches?
> 
> It's usually better to keep those things around.  We could change it
> in the same way we changed the unicode branch, so people are aware
> they're using an obsolete branch.
> 

Did that, thanks.

	Jan D.