23.0.60; Error on zero length completion

23.0.60; Error on zero length completion

[David Hansen]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Hello,

to reproduce:

emacs -Q M-x <TAB>

Fix attached.

2008-04-26  David Hansen  <david.hansen@gmx.net>
        * minibuffer.el (completion-emacs22-try-completion): Check for zero
        length completion.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 974 bytes --]

*** minibuffer.el.~1.27.~	2008-04-24 13:38:54.000000000 +0200
--- minibuffer.el	2008-04-26 01:34:55.000000000 +0200
***************
*** 1002,1008 ****
        ;; Merge a trailing / in completion with a / after point.
        ;; We used to only do it for word completion, but it seems to make
        ;; sense for all completions.
!       (if (and (eq ?/ (aref completion (1- (length completion))))
                 (not (zerop (length suffix)))
                 (eq ?/ (aref suffix 0)))
            ;; This leaves point before the / .
--- 1002,1009 ----
        ;; Merge a trailing / in completion with a / after point.
        ;; We used to only do it for word completion, but it seems to make
        ;; sense for all completions.
!       (if (and (< 0 (length completion))
! 	       (eq ?/ (aref completion (1- (length completion))))
                 (not (zerop (length suffix)))
                 (eq ?/ (aref suffix 0)))
            ;; This leaves point before the / .

[-- Attachment #3: Type: text/plain, Size: 3296 bytes --]


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home/dhansen/share/emacs/23.0.60/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.2 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-04-24 on robotron
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
configured using `configure  '--prefix=/home/dhansen' '--disable-sound' '--disable-pop' '--without-gpm' '--without-toolkit-scroll-bars' '--disable-font-backend' '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: ERC

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  erc-smiley-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  erc-scrolltobottom-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-autojoin-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  shell-dirtrack-mode: t
  flyspell-mode: t
  global-visible-mark-mode: t
  visible-mark-mode: t
  which-function-mode: t
  show-paren-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-compression-mode: t
  line-number-mode: t
  abbrev-mode: 1

Recent input:
M-> c v s SPC C-a C-k s h e l l <return> C-x o C-x 
b s t u g C-g C-x b s t u f f C-g C-x C-f s t u g g 
<backspace> <backspace> f f / s t u g <backspace> f 
f . o r <tab> <return> C-n C-n C-n C-n C-n C-n C-n 
<tab> <tab> C-n C-n C-n C-SPC M-} M-w C-x o C-y <return> 
C-x o C-x o d <backspace> c d SPC ~ / s r <tab> w m 
<tab> <backspace> <backspace> e m <tab> a <tab> <return> 
C-y <return> C-x o C-x b e m a <return> ( s y t e m 
C-a C-k C-h v s y s <tab> h o <tab> <M-backspace> <tab> 
n a <tab> <return> s <backspace> s u <backspace> y 
s t e m - n a m e <return> C-x o C-x b s h e <return> 
M-> n i c e SPC - 1 9 SPC m a k e <return> c d SPC 
l i s <tab> <return> m a k SPC e <backspace> <backspace> 
e SPC r e c o m p i l e SPC E M A C S = . . / s r c 
/ e m a c s <return> c d SPC . . / <return> m a k e 
<return> M-v M-v M-v M-> C-x b e s h <return> M-v M-v 
M-v M-> C-x b s h e <return> c d SPC <backspace> <backspace> 
<backspace> c d SPC s r <tab> <return> . / e m a <tab> 
c <tab> s <tab> <return> M-p SPC - ! <backspace> Q 
<return> C-x o C-x 1 M-x r e p o <tab> r <tab> e m 
<tab> b u <tab> g <backspace> <return>

Recent messages:
Type C-x 4 C-o RET to restore the other window.
Mark set
Partially completed
~/src/emacs/lisp 
~/src/emacs 
Mark set [2 times]
Completed
~/src/emacs/src 
History item: 1
Making completion list...

Re: 23.0.60; Error on zero length completion

[Stefan Monnier]

Indeed, thank you,


        Stefan

Re: 23.0.60; Error on zero length completion

[David Hansen]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 4930 bytes --]

On Fri, 25 Apr 2008 21:31:25 -0400 Stefan Monnier wrote:

> Indeed, thank you,

Similar one:

emacs -Q M-x <SPC>

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  all-completions(nil [nocasify org-agenda-sorting x-dnd-default-test-function inhibit-debug-on-entry gnus-group-various vc-sccs left-triangle pgg-pgp woman-interface make-mode epg eshell-io idlw-help erc-backend delphi wid-browse font-lock-regexp-grouping-backslash rmail-primary-inbox-list org-table-settings name-props bw-adjust-window isearch-process-search-char set-background-color menu-bar-non-minibuffer-window-p Buffer-menu-sort-by-column gulp erc-truncate erc-sound isearch-describe-mode newsticker-headline-processing menu-bar-showhide-fringe-ind-mixed tooltip-help-message tis-620 eol-flag SVN knda Buffer-menu-use-header-line erc-speedbar auto eshell-ls create-fontset-from-ascii-font news-inews-program gnus-article-signature em-term sendmail esh-cmd rfn-eshadow-sifn-equal etl debugger
 -batch-max-lines ebnf2ps ...] commandp)
  completion-pcm--all-completions((any " ") [nocasify org-agenda-sorting x-dnd-default-test-function inhibit-debug-on-entry gnus-group-various vc-sccs left-triangle pgg-pgp woman-interface make-mode epg eshell-io idlw-help erc-backend delphi wid-browse font-lock-regexp-grouping-backslash rmail-primary-inbox-list org-table-settings name-props bw-adjust-window isearch-process-search-char set-background-color menu-bar-non-minibuffer-window-p Buffer-menu-sort-by-column gulp erc-truncate erc-sound isearch-describe-mode newsticker-headline-processing menu-bar-showhide-fringe-ind-mixed tooltip-help-message tis-620 eol-flag SVN knda Buffer-menu-use-header-line erc-speedbar auto eshell-ls create-fontset-from-ascii-font news-inews-program gnus-article-signature em-term sendmail esh-cmd rfn-eshadow-s
 ifn-equal etl debugger-batch-max-lines ebnf2ps ...] commandp)
  completion-pcm-try-completion(" " [nocasify org-agenda-sorting x-dnd-default-test-function inhibit-debug-on-entry gnus-group-various vc-sccs left-triangle pgg-pgp woman-interface make-mode epg eshell-io idlw-help erc-backend delphi wid-browse font-lock-regexp-grouping-backslash rmail-primary-inbox-list org-table-settings name-props bw-adjust-window isearch-process-search-char set-background-color menu-bar-non-minibuffer-window-p Buffer-menu-sort-by-column gulp erc-truncate erc-sound isearch-describe-mode newsticker-headline-processing menu-bar-showhide-fringe-ind-mixed tooltip-help-message tis-620 eol-flag SVN knda Buffer-menu-use-header-line erc-speedbar auto eshell-ls create-fontset-from-ascii-font news-inews-program gnus-article-signature em-term sendmail esh-cmd rfn-eshadow-sifn-equa
 l etl debugger-batch-max-lines ebnf2ps ...] commandp 1)
  #[(style) "\b	žA@\n\v\f
$‡" [style completion-styles-alist string table pred point] 5](partial-completion)
  completion--some(#[(style) "\b	žA@\n\v\f
$‡" [style completion-styles-alist string table pred point] 5] (basic partial-completion))
  completion-try-completion(" " [nocasify org-agenda-sorting x-dnd-default-test-function inhibit-debug-on-entry gnus-group-various vc-sccs left-triangle pgg-pgp woman-interface make-mode epg eshell-io idlw-help erc-backend delphi wid-browse font-lock-regexp-grouping-backslash rmail-primary-inbox-list org-table-settings name-props bw-adjust-window isearch-process-search-char set-background-color menu-bar-non-minibuffer-window-p Buffer-menu-sort-by-column gulp erc-truncate erc-sound isearch-describe-mode newsticker-headline-processing menu-bar-showhide-fringe-ind-mixed tooltip-help-message tis-620 eol-flag SVN knda Buffer-menu-use-header-line erc-speedbar auto eshell-ls create-fontset-from-ascii-font news-inews-program gnus-article-signature em-term sendmail esh-cmd rfn-eshadow-sifn-equal et
 l debugger-batch-max-lines ebnf2ps ...] commandp 1)
  completion--try-word-completion("" [nocasify org-agenda-sorting x-dnd-default-test-function inhibit-debug-on-entry gnus-group-various vc-sccs left-triangle pgg-pgp woman-interface make-mode epg eshell-io idlw-help erc-backend delphi wid-browse font-lock-regexp-grouping-backslash rmail-primary-inbox-list org-table-settings name-props bw-adjust-window isearch-process-search-char set-background-color menu-bar-non-minibuffer-window-p Buffer-menu-sort-by-column gulp erc-truncate erc-sound isearch-describe-mode newsticker-headline-processing menu-bar-showhide-fringe-ind-mixed tooltip-help-message tis-620 eol-flag SVN knda Buffer-menu-use-header-line erc-speedbar auto eshell-ls create-fontset-from-ascii-font news-inews-program gnus-article-signature em-term sendmail esh-cmd rfn-eshadow-sifn-equ
 al etl debugger-batch-max-lines ebnf2ps ...] commandp 0)
  completion--do-completion(completion--try-word-completion)
  minibuffer-complete-word()
  call-interactively(minibuffer-complete-word nil nil)
  execute-extended-command(nil)
  call-interactively(execute-extended-command nil nil)

Re: 23.0.60; Error on zero length completion

[Stefan Monnier]

>> Indeed, thank you,
> emacs -Q M-x <SPC>
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)

I believe I've fixed this one now,


        Stefan


Index: minibuffer.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/minibuffer.el,v
retrieving revision 1.29
diff -u -u -b -r1.29 minibuffer.el
--- minibuffer.el	26 Apr 2008 12:58:13 -0000	1.29
+++ minibuffer.el	28 Apr 2008 13:56:28 -0000
@@ -1131,7 +1131,7 @@
 	   (regex (completion-pcm--pattern->regex pattern))
 	   (completion-regexp-list (cons regex completion-regexp-list))
 	   (compl (all-completions
-                   (if (stringp (car pattern)) (car pattern))
+                   (if (stringp (car pattern)) (car pattern) "")
 		   table pred))
            (last (last compl)))
       ;; FIXME: If `base-size' is not 0, we have a problem :-(