all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 694@emacsbugs.donarmstrong.com
Subject: bug#694: marked as done (23.0.60; wrong behaviour of
Date: Thu, 28 Aug 2008 12:02:21 -0400	[thread overview]
Message-ID: <jwvvdxl6scr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87vdxlw7wb.fsf@cyd.mit.edu> (Chong Yidong's message of "Thu, 28 Aug 2008 10:07:00 -0400")

>>> I believe vc-workfile-unchanged-p and if the two timestamsps are the
>>> same, it can conclude that the file is unchanged, but if the
>>> timestamps are different, it should call the backend specific
>>> workfile-unchanged-p function.
>> 
>> For CVS if the user requested to `stay-local', this is not quite right
>> either since it will connect to the server.  Admittedly, there's no way
>> to get the right answer without connecting to the server, but this
>> behavior has been with us for years and I usually consider it a feature
>> (most/all the CVS servers I use are usually remote/slow/unreachable, so
>> it's important to have control over when VC contacts the server and when
>> it doesn't).

> Should I revert the patch then?

I'm not sure, but I'd tend to think so, yes.


        Stefan






  reply	other threads:[~2008-08-28 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87ljyiyyud.fsf@cyd.mit.edu>
2008-08-11 10:24 ` bug#694: 23.0.60; wrong behaviour of vc-workfile-unchanged-p Alex Harsanyi
2008-08-27 20:45   ` bug#694: marked as done (23.0.60; wrong behaviour of vc-workfile-unchanged-p) Emacs bug Tracking System
2008-08-28  1:31     ` bug#694: marked as done (23.0.60; wrong behaviour of Stefan Monnier
2008-08-28 14:07       ` Chong Yidong
2008-08-28 16:02         ` Stefan Monnier [this message]
2008-08-28 17:50           ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvdxl6scr.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=694@emacsbugs.donarmstrong.com \
    --cc=cyd@stupidchicken.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.