From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-register complains if a file is already registered in a git repository Date: Tue, 21 Oct 2008 21:37:21 -0400 Message-ID: References: <87prlvm2ms.fsf@hagelb.org> <873aipmvt6.fsf@hagelb.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224639458 14409 80.91.229.12 (22 Oct 2008 01:37:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Oct 2008 01:37:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Phil Hagelberg Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 22 03:38:38 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KsSgH-0006ce-PJ for ged-emacs-devel@m.gmane.org; Wed, 22 Oct 2008 03:38:38 +0200 Original-Received: from localhost ([127.0.0.1]:39087 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KsSfC-0007Bo-I8 for ged-emacs-devel@m.gmane.org; Tue, 21 Oct 2008 21:37:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KsSf8-0007BW-4t for emacs-devel@gnu.org; Tue, 21 Oct 2008 21:37:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KsSf5-0007BK-PD for emacs-devel@gnu.org; Tue, 21 Oct 2008 21:37:24 -0400 Original-Received: from [199.232.76.173] (port=41495 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KsSf5-0007BH-JS for emacs-devel@gnu.org; Tue, 21 Oct 2008 21:37:23 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:36949) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KsSf5-0002N4-3i for emacs-devel@gnu.org; Tue, 21 Oct 2008 21:37:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq8EAJsg/khFxLrB/2dsb2JhbACBcsRRg1CBCg X-IronPort-AV: E=Sophos;i="4.33,460,1220241600"; d="scan'208";a="28690863" Original-Received: from 69-196-186-193.dsl.teksavvy.com (HELO ceviche.home) ([69.196.186.193]) by ironport2-out.teksavvy.com with ESMTP; 21 Oct 2008 21:37:22 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id AD861B41C1; Tue, 21 Oct 2008 21:37:21 -0400 (EDT) In-Reply-To: <873aipmvt6.fsf@hagelb.org> (Phil Hagelberg's message of "Tue, 21 Oct 2008 15:23:49 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104804 Archived-At: > I just noticed the existence of the vc-default-could-register function: > Return non-nil if BACKEND could be used to register FILE. > It seems like vc-register should be running this function instead of > vc-registered to check if it should continue, like this: No, could-register is used for other purposes. > Since we're in a feature freeze, perhaps this is ill-advised? Yes. >> It would probably be better for vc-git to provide another command, for that. >> We could probably add a `extra-keys' operation similar to `extra-menu' >> so that vc-git can not only provide a new command but also provide >> a specific C-x v key binding for it. > This would be great if we don't want to make the changes above. I can > add it. Could I get some details about extra-menu though? I'm not > familiar with it. Grep for extra-menu and extra-status-menu (which should be renamed extra-dir-menu, BTW) in vc*.el. Stefan