From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: menu-bar.el: x-selection-exists-p Date: Tue, 03 Mar 2009 09:15:07 -0500 Message-ID: References: <7AD9FA63-6D04-4EC4-8E6D-C6DA7215035B@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236090750 18873 80.91.229.12 (3 Mar 2009 14:32:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Mar 2009 14:32:30 +0000 (UTC) Cc: Emacs-Devel devel To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 03 15:33:46 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LeVgm-0001ln-Qm for ged-emacs-devel@m.gmane.org; Tue, 03 Mar 2009 15:33:45 +0100 Original-Received: from localhost ([127.0.0.1]:40603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LeVfR-0000Ap-HQ for ged-emacs-devel@m.gmane.org; Tue, 03 Mar 2009 09:32:21 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LeVOt-0005LY-6h for emacs-devel@gnu.org; Tue, 03 Mar 2009 09:15:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LeVOn-0005Jp-Ke for emacs-devel@gnu.org; Tue, 03 Mar 2009 09:15:10 -0500 Original-Received: from [199.232.76.173] (port=57941 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LeVOn-0005JN-56 for emacs-devel@gnu.org; Tue, 03 Mar 2009 09:15:09 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:41668 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LeVOm-0004Kp-PE for emacs-devel@gnu.org; Tue, 03 Mar 2009 09:15:08 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAKvKrEnO+KX2/2dsb2JhbACBTtZMhAYGhAE X-IronPort-AV: E=Sophos;i="4.38,296,1233550800"; d="scan'208";a="34625789" Original-Received: from 206-248-165-246.dsl.teksavvy.com (HELO pastel.home) ([206.248.165.246]) by ironport2-out.teksavvy.com with ESMTP; 03 Mar 2009 09:15:07 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 2A901805C; Tue, 3 Mar 2009 09:15:07 -0500 (EST) In-Reply-To: <7AD9FA63-6D04-4EC4-8E6D-C6DA7215035B@gmail.com> (David Reitter's message of "Mon, 2 Mar 2009 23:24:36 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109408 Archived-At: > Are the below changes OK, and is it OK to check this in at this point? The second change is OK (I'd fold the "if" into that "and", but that's just me). The first doesn't seem quite right: I think it should test something like: (or (and (fboundp 'x-selection-exists-p) (x-selection-exists-p)) kill-ring) to better reflect the fact that `yank' either uses the selection or the kill-ring. Thanks for spotting this. Stefan