From: Stefan Monnier <monnier@iro.umontreal.ca>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: "Chong Yidong" <cyd@stupidchicken.com>,
emacs-devel@gnu.org, ez <ismail@namtrac.org>
Subject: Re: [PATCH] XCloseDisplay already calls XrmDestroyDatabase
Date: Sun, 17 May 2009 17:40:50 -0400 [thread overview]
Message-ID: <jwvvdnzbe7u.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <wlab5gmumv.wl%mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Thu, 14 May 2009 08:48:56 +0900")
>> If we remove the XrmDestroyDatabase call unconditionally, then it
>> causes a memory leak when used with a newer libX11. But that would
>> be better than crashing when used with an older one.
> Or maybe we can dissociate the resource database from the display
> before closing it.
> #ifdef HAVE_XRMSETDATABASE
> XrmSetDatabase (dpyinfo->display, NULL);
> #else
dpyinfo-> display->db = NULL;
> #endif
> Then we can ignore the difference of libX11 at least for normal close.
Sounds OK as well.
Stefan
next prev parent reply other threads:[~2009-05-17 21:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 10:19 [PATCH] XCloseDisplay already calls XrmDestroyDatabase İsmail Dönmez
2008-08-20 8:17 ` İsmail Dönmez
2008-08-21 18:40 ` İsmail Dönmez
2008-08-21 19:43 ` Chong Yidong
2008-07-20 20:51 ` bug#581: 23.0.60; OSX: server crashes when quitting emacsclient Markus Triska
[not found] ` <handler.581.B.121658711315039.ack@emacsbugs.donarmstrong.com>
2008-08-08 12:08 ` bug#581: Acknowledgement (23.0.60; OSX: server crashes when quitting emacsclient) Markus Triska
2008-08-09 1:02 ` ＯＦＦＩＣＥ ZERO
2008-08-09 14:12 ` ＯＦＦＩＣＥ ZERO
2008-08-21 19:50 ` bug#581: marked as done " Emacs bug Tracking System
2009-05-13 3:27 ` [PATCH] XCloseDisplay already calls XrmDestroyDatabase YAMAMOTO Mitsuharu
2009-05-13 23:48 ` YAMAMOTO Mitsuharu
2009-05-17 21:40 ` Stefan Monnier [this message]
2009-05-18 8:09 ` YAMAMOTO Mitsuharu
2009-05-18 13:29 ` Chong Yidong
2009-05-17 21:40 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvdnzbe7u.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=ismail@namtrac.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.