From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Tetsurou Okazaki <okazaki@be.to>
Cc: 6490@debbugs.gnu.org
Subject: bug#6490: 24.0.50; src/lread.c: old style backquote bug?
Date: Sun, 04 Jul 2010 23:50:26 +0200 [thread overview]
Message-ID: <jwvvd8vx7fc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8639w3vjvm.wl%%cc9230e4f6b11649d75e8c3813911dbe1dd37419@be.to> (Tetsurou Okazaki's message of "Thu, 01 Jul 2010 14:41:49 +0900")
>> > Attached patch for Emacs fixes this error.
>> I'm glad the patch fixes things for you, since this patch indeed looks
>> perfectly harmless, but I'm a bit puzzled because it doesn't just look
>> harmless: it looks to me like the patch does change anything to the way
>> the code works. So could you explain to me how&why the patch fixes
>> the problem? I'm probably just overlooking some "obvious" detail,
> The changes committed in rev:100605 reassigns the next character to
> the variable `c'. When the next character is SPC (32, #o40, #x20),
> old style backquote is detected.
> if (first_in_list && (c = READCHAR, UNREAD (c), c == ' '))
> {
> Vold_style_backquotes = Qt;
> goto default_label;
> }
> But backquote handling is skipped because `c' is SPC.
> default_label:
> if (c <= 040) goto retry;
> ... old style backquote handling ...
> My patch avoids reassignment of `c' not to skip old style
> backquote handling.
Thanks, that makes perfect sense now. I've installed it now.
> To keep more compatibility with released Emacs, it is preferable to
> allow a character such as \r or \n after the old style backquote.
I haven't seen any such situation yet, and since old-style backquotes are
on the way out (effectively obsolete since something like Emacs-20, and
officially obsolete since Emacs-22.1), I'll wait to see actual cases
before adding such exceptions,
Stefan
next prev parent reply other threads:[~2010-07-04 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 9:16 bug#6490: 24.0.50; src/lread.c: old style backquote bug? Tetsurou Okazaki
2010-06-22 22:23 ` Stefan Monnier
2010-07-01 4:14 ` Makoto Fujiwara
2010-07-01 5:41 ` Tetsurou Okazaki
2010-07-04 21:50 ` Stefan Monnier [this message]
2010-07-04 23:58 ` Makoto Fujiwara
2011-09-21 20:54 ` Lars Magne Ingebrigtsen
2011-09-22 1:43 ` Stefan Monnier
2010-07-05 1:51 ` Makoto Fujiwara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvd8vx7fc.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=6490@debbugs.gnu.org \
--cc=okazaki@be.to \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.