From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: John Wiegley <jwiegley@gmail.com>, 7585@debbugs.gnu.org
Subject: bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input
Date: Mon, 13 Dec 2010 12:00:19 -0500 [thread overview]
Message-ID: <jwvvd2xy5gf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m18w01o1r8.fsf@cam.ac.uk> (Leo's message of "Tue, 07 Dec 2010 18:51:07 +0000")
> There is a customisable variable eshell-hist-move-to-end when set to
> nil, point is not guaranteed to be located behind
> eshell-last-output-end. Thus blindly calling delete-region and
> insert-and-inherit will generate an error in that case.
The patch looks good as well, tho we usually prefer not to use `assert'
in this way (I'd keep assert for actual coding errors, so better use an
if test that then `signal's an error).
Stefan
next prev parent reply other threads:[~2010-12-13 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 18:51 bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input Leo
2010-12-13 17:00 ` Stefan Monnier [this message]
2010-12-13 18:31 ` Leo
2010-12-13 20:42 ` Stefan Monnier
2010-12-14 6:13 ` Leo
2010-12-14 19:46 ` Stefan Monnier
2010-12-17 11:04 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvd2xy5gf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7585@debbugs.gnu.org \
--cc=jwiegley@gmail.com \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.