From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/2] progmodes/vhdl-mode.el: Backported changes from 3.33. Date: Thu, 24 May 2012 00:33:18 -0400 Message-ID: References: <11841062.XUGkREX5ia@descartes> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337834793 428 80.91.229.3 (24 May 2012 04:46:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 24 May 2012 04:46:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?iso-8859-1?Q?R=FCdiger?= Sonderfeld Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 24 06:46:31 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SXPwQ-00044A-MP for ged-emacs-devel@m.gmane.org; Thu, 24 May 2012 06:46:26 +0200 Original-Received: from localhost ([::1]:40787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXPjr-0003IY-2s for ged-emacs-devel@m.gmane.org; Thu, 24 May 2012 00:33:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXPjo-0003ID-W1 for emacs-devel@gnu.org; Thu, 24 May 2012 00:33:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXPjl-0002xD-Hl for emacs-devel@gnu.org; Thu, 24 May 2012 00:33:24 -0400 Original-Received: from ironport-out.teksavvy.com ([206.248.143.162]:55881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXPjl-0002wM-Dp for emacs-devel@gnu.org; Thu, 24 May 2012 00:33:21 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EAG6Zu09MCpYd/2dsb2JhbABEFrN7gQiCFQEBBAFWIwULCzQSFBgNJIgcBQu5fpBEA6MzgViDBQ X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="182149397" Original-Received: from 76-10-150-29.dsl.teksavvy.com (HELO pastel.home) ([76.10.150.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 May 2012 00:33:18 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4771858C01; Thu, 24 May 2012 00:33:18 -0400 (EDT) In-Reply-To: <11841062.XUGkREX5ia@descartes> (=?iso-8859-1?Q?=22R=FCdiger?= Sonderfeld"'s message of "Wed, 23 May 2012 14:53:29 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.143.162 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150625 Archived-At: > http://www.iis.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html#release-notes-3.33 > Among the changes are > * Support for ghdl (free vhdl compiler). Now default > * Add/update support for VHDL-AMS packages. > * Update to VHDL'02 standard > ... > I tried to be very careful not to overwrite any non-upstream changes > that were made to vhdl-mode. Thanks. Your patch got corrupted by line-wrapping. Could you please resend it, maybe as a mime-attachment? Also, while I'm here: are you the vhdl-mode maintainer, or are you simply helping sync the two versions? Regarding the code I haven't reviewed it, but I noticed that it advertises C-c C-c for commenting code, whereas it should advertise M-; instead. Regarding the second patch you sent: I'm more interested in reducing the difference between the two versions of vhdl-mode than in making our version compile without warnings, so I think we're better off without this patch, unless it's accepted in the upstream version of the code. Also, while I'm here, do you also sync changes from Emacs's repository back to the upstream version? E.g. the use of syntax-propertize-function. Stefan