From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 1/2] progmodes/vhdl-mode.el: Backported changes from 3.33.
Date: Thu, 24 May 2012 00:33:18 -0400 [thread overview]
Message-ID: <jwvvcjmdx4e.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <11841062.XUGkREX5ia@descartes> ("Rüdiger Sonderfeld"'s message of "Wed, 23 May 2012 14:53:29 +0200")
> http://www.iis.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html#release-notes-3.33
> Among the changes are
> * Support for ghdl (free vhdl compiler). Now default
> * Add/update support for VHDL-AMS packages.
> * Update to VHDL'02 standard
> ...
> I tried to be very careful not to overwrite any non-upstream changes
> that were made to vhdl-mode.
Thanks. Your patch got corrupted by line-wrapping. Could you please
resend it, maybe as a mime-attachment?
Also, while I'm here: are you the vhdl-mode maintainer, or are you
simply helping sync the two versions?
Regarding the code I haven't reviewed it, but I noticed that it
advertises C-c C-c for commenting code, whereas it should advertise M-;
instead.
Regarding the second patch you sent: I'm more interested in reducing the
difference between the two versions of vhdl-mode than in making our
version compile without warnings, so I think we're better off without
this patch, unless it's accepted in the upstream version of the code.
Also, while I'm here, do you also sync changes from Emacs's repository
back to the upstream version? E.g. the use of syntax-propertize-function.
Stefan
next prev parent reply other threads:[~2012-05-24 4:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 12:53 [PATCH 1/2] progmodes/vhdl-mode.el: Backported changes from 3.33 Rüdiger Sonderfeld
2012-05-24 4:33 ` Stefan Monnier [this message]
2012-05-24 17:05 ` Rüdiger Sonderfeld
2012-05-28 3:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvcjmdx4e.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=ruediger@c-plusplus.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.