From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Oleksandr Gavenko <gavenkoa@gmail.com>
Cc: 12747@debbugs.gnu.org
Subject: bug#12747: 23.4; diff-auto-refine-mode process only last hunk in diff (must ALL).
Date: Sun, 28 Oct 2012 09:54:22 -0400 [thread overview]
Message-ID: <jwvvcdusoi9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y5iqbxqn.fsf@gavenkoa.example.com> (Oleksandr Gavenko's message of "Sun, 28 Oct 2012 14:13:36 +0200")
> If I enable diff-auto-refine-mode in all diff-mode buffers:
> (defun my-diff-auto-refine-mode-on () (diff-auto-refine-mode 1))
> (add-hook 'diff-mode-hook 'my-diff-auto-refine-mode-on)
> I see actions only on last hunk in diff.
I'm not sure I understand what you mean. `diff-auto-refine-mode' does
not refine-highlight all the hunks at once (quoting the docstring):
When enabled, Emacs automatically highlights
changes in detail as the user visits hunks.
"as the user visits the hunks" means that it's only highlighted in
response to "n" and "p" (and a few related operations).
This is not a bug. IIUC you'd like the refinement to be done in any
hunk that is ever displayed, right?
If so, that is a valid request for enhancement, and I fully agree.
If someone is interested in implementing it, here's how I think it would
have to work:
- add a font-lock-keywords rule in diff-mode which simply registers the
region displayed in a buffer-local var `diff--regions-displayed'.
- have an idle timer that checks `diff--regions-displayed' and refines
all the hunks in those regions (and it should also font-lock those
hunks at the same time, so that if some of the hunk is not yet
displayed and not yet font-locked, displaying it later on won't cause
re-refining the hunk).
Stefan
next prev parent reply other threads:[~2012-10-28 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 12:13 bug#12747: 23.4; diff-auto-refine-mode process only last hunk in diff (must ALL) Oleksandr Gavenko
2012-10-28 13:54 ` Stefan Monnier [this message]
2012-10-28 19:38 ` Oleksandr Gavenko
2012-10-28 20:29 ` Stefan Monnier
2018-07-12 0:28 ` Noam Postavsky
2018-07-12 13:28 ` Stefan Monnier
2018-07-12 19:54 ` Noam Postavsky
2018-07-12 20:17 ` Stefan Monnier
2018-07-13 1:47 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvcdusoi9.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12747@debbugs.gnu.org \
--cc=gavenkoa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.