From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500) Date: Thu, 15 Nov 2012 09:39:14 -0500 Message-ID: References: <87haoyl4on.fsf@topper.koldfront.dk> <87625bw1jx.fsf@visionobjects.com> <87pq3fxmta.fsf@googlemail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1352990372 13069 80.91.229.3 (15 Nov 2012 14:39:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Nov 2012 14:39:32 +0000 (UTC) Cc: lekktu@gmail.com, asjo@koldfront.dk, ivan.kanis@googlemail.com, emacs-devel@gnu.org To: Katsumi Yamaoka Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 15 15:39:42 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TZ0bS-0001T9-CM for ged-emacs-devel@m.gmane.org; Thu, 15 Nov 2012 15:39:38 +0100 Original-Received: from localhost ([::1]:38290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ0bI-0007gL-EM for ged-emacs-devel@m.gmane.org; Thu, 15 Nov 2012 09:39:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ0bE-0007fz-1g for emacs-devel@gnu.org; Thu, 15 Nov 2012 09:39:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZ0bA-0004Nt-Uk for emacs-devel@gnu.org; Thu, 15 Nov 2012 09:39:23 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:19962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ0bA-0004Nj-R2 for emacs-devel@gnu.org; Thu, 15 Nov 2012 09:39:20 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09sr+ZY/2dsb2JhbABEsEiDSYEIghYBBVYjEAs0EhQYDSSIIboJiwiFPAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="207677803" Original-Received: from 108-175-230-88.dsl.teksavvy.com (HELO pastel.home) ([108.175.230.88]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 15 Nov 2012 09:39:19 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 68B3B594C8; Thu, 15 Nov 2012 09:39:14 -0500 (EST) In-Reply-To: (Katsumi Yamaoka's message of "Thu, 15 Nov 2012 19:55:53 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154871 Archived-At: >>>> With these changes, so far I can play with Emacs as before. >>> Thanks, installed, >> I tried it this morning and it's fixed. Thank you Stefan. > Unfortunately called-interactively-p never returns non-nil while > performing an advised command interactively. Yes, called-interactively-p (and interactivep, of course) are pretty sensitive beasts. The problem you mention was already present before, tho it probably got a bit worse (it used to "only" affect uses of called-interactively-p in the advised command, whereas it now also affects uses in the advice themselves). Stefan