From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: lekktu@gmail.com, asjo@koldfront.dk, ivan.kanis@googlemail.com,
emacs-devel@gnu.org
Subject: Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500)
Date: Thu, 15 Nov 2012 09:39:14 -0500 [thread overview]
Message-ID: <jwvvcd7vspd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <b4mpq3fgmo6.fsf@jpl.org> (Katsumi Yamaoka's message of "Thu, 15 Nov 2012 19:55:53 +0900")
>>>> With these changes, so far I can play with Emacs as before.
>>> Thanks, installed,
>> I tried it this morning and it's fixed. Thank you Stefan.
> Unfortunately called-interactively-p never returns non-nil while
> performing an advised command interactively.
Yes, called-interactively-p (and interactivep, of course) are pretty
sensitive beasts. The problem you mention was already present before,
tho it probably got a bit worse (it used to "only" affect uses of
called-interactively-p in the advised command, whereas it now also
affects uses in the advice themselves).
Stefan
next prev parent reply other threads:[~2012-11-15 14:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 23:47 Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500) Adam Sjøgren
2012-11-10 1:55 ` Stefan Monnier
2012-11-11 21:24 ` Tim Cross
2012-11-12 10:36 ` Ivan Kanis
2012-11-13 11:09 ` Katsumi Yamaoka
2012-11-13 14:34 ` Stefan Monnier
2012-11-13 23:18 ` Katsumi Yamaoka
2012-11-14 16:19 ` Juanma Barranquero
2012-11-15 2:08 ` Katsumi Yamaoka
2012-11-15 3:30 ` Stefan Monnier
2012-11-15 9:00 ` Ivan Kanis
2012-11-15 10:55 ` Katsumi Yamaoka
2012-11-15 14:39 ` Stefan Monnier [this message]
2012-11-15 23:01 ` Katsumi Yamaoka
2012-11-16 14:16 ` Stefan Monnier
2012-11-16 16:33 ` Juanma Barranquero
2012-11-16 17:25 ` Stefan Monnier
2012-11-16 17:36 ` Juanma Barranquero
2012-11-16 18:11 ` Stefan Monnier
2012-11-16 18:17 ` Juanma Barranquero
2012-11-16 20:11 ` Stefan Monnier
2012-11-16 23:52 ` Juanma Barranquero
2012-11-19 1:29 ` Stefan Monnier
2012-11-19 2:36 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvcd7vspd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=asjo@koldfront.dk \
--cc=emacs-devel@gnu.org \
--cc=ivan.kanis@googlemail.com \
--cc=lekktu@gmail.com \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.