From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching text outside filenames Date: Thu, 21 Mar 2013 21:59:52 -0400 Message-ID: References: <87li9hk5e5.fsf@web.de> <87wqt1vd0o.fsf@mail.jurta.org> <87d2ut4mji.fsf@web.de> <87620lvavl.fsf@mail.jurta.org> <87zjxxsd6c.fsf@web.de> <87vc8ke4os.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1363917675 2896 80.91.229.3 (22 Mar 2013 02:01:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Mar 2013 02:01:15 +0000 (UTC) Cc: Michael Heerdegen , 14013@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 22 03:01:37 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UIrIW-0000QX-UX for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Mar 2013 03:01:37 +0100 Original-Received: from localhost ([::1]:58491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIrI9-0005nQ-IK for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2013 22:01:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIrI6-0005mH-1z for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2013 22:01:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIrI5-0000dG-5a for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2013 22:01:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIrI5-0000dC-1Z for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2013 22:01:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UIrJt-0006RM-Qx for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2013 22:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2013 02:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14013 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14013-submit@debbugs.gnu.org id=B14013.136391773324701 (code B ref 14013); Fri, 22 Mar 2013 02:03:01 +0000 Original-Received: (at 14013) by debbugs.gnu.org; 22 Mar 2013 02:02:13 +0000 Original-Received: from localhost ([127.0.0.1]:39692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UIrIz-0006QE-Sp for submit@debbugs.gnu.org; Thu, 21 Mar 2013 22:02:10 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:4227) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UIrIw-0006Pt-Jq for 14013@debbugs.gnu.org; Thu, 21 Mar 2013 22:02:03 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxKvA/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IPAS-Result: Av8EABK/CFFFxKvA/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="5501829" Original-Received: from 69-196-171-192.dsl.teksavvy.com (HELO pastel.home) ([69.196.171.192]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 Mar 2013 22:00:03 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B396567AC3; Thu, 21 Mar 2013 21:59:52 -0400 (EDT) In-Reply-To: <87vc8ke4os.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 22 Mar 2013 01:03:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72782 Archived-At: > - (pos1 (save-excursion (funcall func string bound noerror))) > + (pos1 (save-excursion > + (run-hooks 'isearch-search-fun-pre-hook) > + (funcall func string bound noerror))) Doesn't sound good. > + (add-hook 'isearch-search-fun-pre-hook 'dired-isearch-filenames-pre-hook nil t))) Why not (add-function :around (local isearch-search-fun-function) #'dired--isearch-filenames) and then (defun dired--isearch-filenames (iiff &rest args) (let ((fun (apply iiff args))) (lambda (&rest args) (unless (get-text-property (point) 'dired-filename) (if isearch-forward (goto-char (or (next-single-property-change (point) 'dired-filename) (point-max))) (goto-char (or (previous-single-property-change (point) 'dired-filename) (point-min))))) (apply fun args)))) -- Stefan