From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Huge file adventure (+patch) Date: Mon, 07 Oct 2013 15:03:04 -0400 Message-ID: References: <5252832E.5060804@yandex.ru> <5252DB40.2060702@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1381172601 17036 80.91.229.3 (7 Oct 2013 19:03:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Oct 2013 19:03:21 +0000 (UTC) Cc: Emacs development discussions To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 07 21:03:24 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VTG5T-0003EL-9G for ged-emacs-devel@m.gmane.org; Mon, 07 Oct 2013 21:03:23 +0200 Original-Received: from localhost ([::1]:32988 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTG5S-00062a-Oe for ged-emacs-devel@m.gmane.org; Mon, 07 Oct 2013 15:03:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTG5J-00061h-0t for emacs-devel@gnu.org; Mon, 07 Oct 2013 15:03:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTG5B-0003fG-JT for emacs-devel@gnu.org; Mon, 07 Oct 2013 15:03:12 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:31100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTG5B-0003et-Ey for emacs-devel@gnu.org; Mon, 07 Oct 2013 15:03:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+K8t/2dsb2JhbABEvw4Xc4IeAQEEAScvIwULCw4mEhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av4EABK/CFHO+K8t/2dsb2JhbABEvw4Xc4IeAQEEAScvIwULCw4mEhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="34956544" Original-Received: from 206-248-175-45.dsl.teksavvy.com (HELO pastel.home) ([206.248.175.45]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Oct 2013 14:59:26 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4DAE660C2E; Mon, 7 Oct 2013 15:03:04 -0400 (EDT) In-Reply-To: <5252DB40.2060702@yandex.ru> (Dmitry Antipov's message of "Mon, 07 Oct 2013 20:03:12 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163963 Archived-At: >> You can remove the { between "else" and "if" (with the side-benefit that >> the unchanged code will stay at the same indentation level). > Argh, OK. >> Where/how do you make sure we loop back here for the rest >> (when end-start > E_WRITE_MAX) ? > Did you mean 'end - start < E_WRITE_MAX'? No. > Or am I creating an endless loop in e_write (BTW, I don't see how)? Oh, sorry, I now see that the "start += coding->consumed_char;" makes sure that if we don't encode the whole text at once, the loop will come back to let us finish. Please install. Stefan