From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default. Date: Fri, 01 Nov 2013 13:46:31 -0400 Message-ID: References: <61BBE6C8D4D349B6963A0F429237A3A8@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1383328013 4952 80.91.229.3 (1 Nov 2013 17:46:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Nov 2013 17:46:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 01 18:46:56 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VcIo6-0003ui-FR for ged-emacs-devel@m.gmane.org; Fri, 01 Nov 2013 18:46:50 +0100 Original-Received: from localhost ([::1]:39319 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcIo6-0004is-2P for ged-emacs-devel@m.gmane.org; Fri, 01 Nov 2013 13:46:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcInv-0004iS-9s for emacs-devel@gnu.org; Fri, 01 Nov 2013 13:46:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VcInp-0000Pw-VD for emacs-devel@gnu.org; Fri, 01 Nov 2013 13:46:39 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:46479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcInp-0000Pq-QS for emacs-devel@gnu.org; Fri, 01 Nov 2013 13:46:33 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rA1HkWX2004888; Fri, 1 Nov 2013 13:46:32 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 04C19B420C; Fri, 1 Nov 2013 13:46:31 -0400 (EDT) In-Reply-To: <61BBE6C8D4D349B6963A0F429237A3A8@gmail.com> (Bozhidar Batsov's message of "Fri, 1 Nov 2013 14:59:51 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4749=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4749> : inlines <196> : streams <1066251> : uri <1582821> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164817 Archived-At: > Since Ruby 1.8 reached end of life in the summer and most projects these > days use Ruby 2.0 (which assumes source files use utf8 by default) having > ruby-insert-encoding-magic-comment=E2=80=99 doesn=E2=80=99t make much sen= se. Most people > just disable it anyways, so why not have it disabled by default?=20=20 IIUC, Ruby-2.0 doesn't require source code to be utf-8, so the magic-comment is not obsolete. IOW, what needs to be done is to make Emacs prefer utf-8 for ruby files (it's probably the case already), and to make ruby-mode-set-encoding only insert the magic comment if it is different from utf-8. Stefan "not a Ruby user" PS: The `ruby' package in Debian stable is still at 1.9.1.