From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: The fixes-bug field Date: Fri, 17 Jan 2014 11:12:25 -0500 Message-ID: References: <20140116141315.CA3BE380835@snark.thyrsus.com> <20140116163011.GC17303@thyrsus.com> <83d2jr3ly9.fsf@gnu.org> <20140116180809.GB17770@thyrsus.com> <8338kn3ha8.fsf@gnu.org> <20140116200456.GK17770@thyrsus.com> <83zjmv1upy.fsf@gnu.org> <20140116214714.GA19493@thyrsus.com> <83sisn12sk.fsf@gnu.org> <52D8E29F.6040004@cs.ucla.edu> <87mwiuzjm0.fsf@building.gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389975171 20890 80.91.229.3 (17 Jan 2014 16:12:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jan 2014 16:12:51 +0000 (UTC) Cc: esr@thyrsus.com, Eli Zaretskii , Paul Eggert , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 17 17:12:53 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W4C2O-0002Vd-0Z for ged-emacs-devel@m.gmane.org; Fri, 17 Jan 2014 17:12:52 +0100 Original-Received: from localhost ([::1]:38990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4C2N-0000gB-J2 for ged-emacs-devel@m.gmane.org; Fri, 17 Jan 2014 11:12:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4C2E-0000ec-FD for emacs-devel@gnu.org; Fri, 17 Jan 2014 11:12:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4C27-0003ML-6a for emacs-devel@gnu.org; Fri, 17 Jan 2014 11:12:42 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:8928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4C1z-0003Fp-9z; Fri, 17 Jan 2014 11:12:27 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCoyj/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kLIdyBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFFMCoyj/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kLIdyBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="45192765" Original-Received: from 76-10-140-163.dsl.teksavvy.com (HELO pastel.home) ([76.10.140.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 17 Jan 2014 11:12:26 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 086A16009C; Fri, 17 Jan 2014 11:12:26 -0500 (EST) In-Reply-To: <87mwiuzjm0.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Fri, 17 Jan 2014 16:57:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168631 Archived-At: > I'd suggest extending this to (fixes bug#16372). That way you can refer > to bugs without saying that you've fixed them. (I.e., the syntax is > ( bug#number [optional stuff]).) When we started using such bug#NNN in the ChangeLog (and commit logs) I indeed wanted to use to mean "fixes bug NNN", even hoping that we could write some commit hook that would automatically close the bug. But in practice, I'm often not actually sure that the patch will fix the bug when I commit it (e.g. because the recipe given in the bug-report is clearly a subcase of the OP's real life problem, so I can't be sure the real life problem will be fixed as well). IOW, in many/most situations I only find out after committing that the patch really fixes the bug. So it would work if the "fixes bug#NNN" can be added via something like "git notes", but it won't work well in the commit message itself. Stefan