From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16708: 24.3.50; font-lock nadvice mechanism Date: Mon, 10 Feb 2014 11:57:23 -0500 Message-ID: References: <87r47b14vp.fsf@yahoo.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1392051496 27663 80.91.229.3 (10 Feb 2014 16:58:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Feb 2014 16:58:16 +0000 (UTC) Cc: 16708@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 10 17:58:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WCuBY-0006uD-Az for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Feb 2014 17:58:20 +0100 Original-Received: from localhost ([::1]:56662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCuBY-0006YG-1z for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Feb 2014 11:58:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCuBO-0006Xr-6h for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2014 11:58:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCuBG-0001w0-Tb for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2014 11:58:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCuBG-0001vw-QC for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2014 11:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WCuBG-0002P2-4p for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2014 11:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Feb 2014 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16708-submit@debbugs.gnu.org id=B16708.13920514529195 (code B ref 16708); Mon, 10 Feb 2014 16:58:02 +0000 Original-Received: (at 16708) by debbugs.gnu.org; 10 Feb 2014 16:57:32 +0000 Original-Received: from localhost ([127.0.0.1]:41556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCuAm-0002OF-1Y for submit@debbugs.gnu.org; Mon, 10 Feb 2014 11:57:32 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:55269) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCuAj-0002Nz-RY for 16708@debbugs.gnu.org; Mon, 10 Feb 2014 11:57:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+KAF/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFHO+KAF/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="47206734" Original-Received: from 206-248-160-5.dsl.teksavvy.com (HELO pastel.home) ([206.248.160.5]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Feb 2014 11:57:24 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 07AB3616C6; Mon, 10 Feb 2014 11:57:24 -0500 (EST) In-Reply-To: <87r47b14vp.fsf@yahoo.fr> (Nicolas Richard's message of "Mon, 10 Feb 2014 14:20:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:85276 Archived-At: > I suggest to add `add-function' and `advice-add' (which are used instead > of defadvice at some places) to the font-lock in lisp mode, just as > defadvice is. It might be OK for advice-add but I'm not sure it makes sense for add-function. > Perhaps lisp-imenu-generic-expression should be updated too, I don't > know what it is exactly. No, imenu should point to the "definition site", whereas advice-add does not define a function, it merely modifies it. Stefan