From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dima Kogan <dima@secretsauce.net>
Cc: 18861-done@debbugs.gnu.org
Subject: bug#18861: Acknowledgement (25.0.50; gfile-based file notifications are not immediate)
Date: Wed, 05 Nov 2014 22:02:57 -0500 [thread overview]
Message-ID: <jwvvbmtrqfh.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <877fz9cv12.fsf@secretsauce.net> (Dima Kogan's message of "Wed, 05 Nov 2014 11:19:46 -0800")
Thanks Dima,
Seeing as noone made any comment, I just installed your patch (with minor
tweaks) and hope it does the right thing.
Stefan
> + if (g_main_context_acquire(context))
^^
Missing space before paren.
> + n_gfds = context_acquired ?
> + g_main_context_query (context, G_PRIORITY_LOW, &tmo_in_millisec,
> + gfds, gfds_size) :
> + -1;
The GNU coding style recommends to break lines before rather than after
operators.
> + g_main_context_release(context);
^^
Same.
next prev parent reply other threads:[~2014-11-06 3:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 0:29 bug#18861: 25.0.50; gfile-based file notifications are not immediate Dima Kogan
[not found] ` <handler.18861.B.14144561857404.ack@debbugs.gnu.org>
2014-10-28 4:22 ` bug#18861: Acknowledgement (25.0.50; gfile-based file notifications are not immediate) Dima Kogan
2014-10-28 21:30 ` Dima Kogan
2014-10-30 16:12 ` Stefan Monnier
2014-11-05 19:19 ` Dima Kogan
2014-11-06 3:02 ` Stefan Monnier [this message]
2014-11-06 8:37 ` Michael Albinus
2014-11-06 18:26 ` Dima Kogan
2014-11-06 23:35 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvbmtrqfh.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=18861-done@debbugs.gnu.org \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.