From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 8f03888: * lisp/gnus/gnus-art.el: Fix up compiler warnings. Date: Thu, 15 Jan 2015 17:44:36 -0500 Message-ID: References: <20141218182000.19577.72337@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421361888 7895 80.91.229.3 (15 Jan 2015 22:44:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Jan 2015 22:44:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 15 23:44:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YBt9j-0001UY-EC for ged-emacs-devel@m.gmane.org; Thu, 15 Jan 2015 23:44:47 +0100 Original-Received: from localhost ([::1]:53216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBt9i-0004A6-KH for ged-emacs-devel@m.gmane.org; Thu, 15 Jan 2015 17:44:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBt9d-00049y-Su for emacs-devel@gnu.org; Thu, 15 Jan 2015 17:44:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBt9a-0003WR-Mz for emacs-devel@gnu.org; Thu, 15 Jan 2015 17:44:41 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:34206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBt9a-0003WI-IV for emacs-devel@gnu.org; Thu, 15 Jan 2015 17:44:38 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t0FMibGs015573; Thu, 15 Jan 2015 17:44:37 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id EF3BAA32; Thu, 15 Jan 2015 17:44:36 -0500 (EST) In-Reply-To: (Lars Magne Ingebrigtsen's message of "Thu, 15 Jan 2015 22:58:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5187=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5187> : inlines <1782> : streams <1374000> : uri <1842531> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181310 Archived-At: > Looking at the macro, it looks like it tries to ensure that the buffer > is unibyte, executes the form, and then returns the buffer to its > previous byteness state? Right, and this makes no sense. As a general rule the unibyte/multibyte state of a buffer should only be changed when the buffer is empty. Anything else is just a gross hack that will sooner or later bite you. > Looking at the callers, it seems like that's what they want, although > I'm not sure. The problem is that "change the buffer to uni/multibyte" doesn't itself have a clear meaning, so yes: it's not clear what they want *because* they use this macro. It'll have to be fixed by hand, one by one, either by understanding better what the code needs, or if that's too hard, by trial-and-error (and adding corresponding tests). Stefan