From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 8f03888: * lisp/gnus/gnus-art.el: Fix up compiler warnings.
Date: Thu, 15 Jan 2015 17:44:36 -0500 [thread overview]
Message-ID: <jwvvbk7u0r7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3vbk7d7uw.fsf@gnus.org> (Lars Magne Ingebrigtsen's message of "Thu, 15 Jan 2015 22:58:15 +0100")
> Looking at the macro, it looks like it tries to ensure that the buffer
> is unibyte, executes the form, and then returns the buffer to its
> previous byteness state?
Right, and this makes no sense. As a general rule the unibyte/multibyte
state of a buffer should only be changed when the buffer is empty.
Anything else is just a gross hack that will sooner or later bite you.
> Looking at the callers, it seems like that's what they want, although
> I'm not sure.
The problem is that "change the buffer to uni/multibyte" doesn't itself
have a clear meaning, so yes: it's not clear what they want *because*
they use this macro.
It'll have to be fixed by hand, one by one, either by understanding
better what the code needs, or if that's too hard, by trial-and-error
(and adding corresponding tests).
Stefan
next prev parent reply other threads:[~2015-01-15 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141218182000.19577.72337@vcs.savannah.gnu.org>
[not found] ` <E1Y1fgA-00056N-7o@vcs.savannah.gnu.org>
2015-01-15 21:58 ` master 8f03888: * lisp/gnus/gnus-art.el: Fix up compiler warnings Lars Magne Ingebrigtsen
2015-01-15 22:44 ` Stefan Monnier [this message]
2015-01-15 23:12 ` Lars Magne Ingebrigtsen
2015-01-16 2:07 ` Stefan Monnier
2015-01-16 2:22 ` Lars Magne Ingebrigtsen
2015-01-16 8:54 ` Eli Zaretskii
2015-01-16 16:09 ` Lars Magne Ingebrigtsen
2015-01-16 8:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvbk7u0r7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.