Re: master 8f03888: * lisp/gnus/gnus-art.el: Fix up compiler warnings.

[Stefan Monnier <monnier@IRO.UMontreal.CA>]

> Looking at the macro, it looks like it tries to ensure that the buffer
> is unibyte, executes the form, and then returns the buffer to its
> previous byteness state?

Right, and this makes no sense.  As a general rule the unibyte/multibyte
state of a buffer should only be changed when the buffer is empty.
Anything else is just a gross hack that will sooner or later bite you.

> Looking at the callers, it seems like that's what they want, although
> I'm not sure.

The problem is that "change the buffer to uni/multibyte" doesn't itself
have a clear meaning, so yes: it's not clear what they want *because*
they use this macro.

It'll have to be fixed by hand, one by one, either by understanding
better what the code needs, or if that's too hard, by trial-and-error
(and adding corresponding tests).


        Stefan