From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20276: 24.4; diff-mode doesn't handle unified diff file headers without tabs Date: Wed, 08 Apr 2015 21:48:49 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1428544165 3095 80.91.229.3 (9 Apr 2015 01:49:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Apr 2015 01:49:25 +0000 (UTC) Cc: 20276-done@debbugs.gnu.org To: Gustav =?UTF-8?Q?H=C3=A5llberg?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 09 03:49:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yg1ai-0005Jf-EM for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Apr 2015 03:49:12 +0200 Original-Received: from localhost ([::1]:55851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yg1ah-0002Lh-So for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Apr 2015 21:49:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yg1ad-0002JQ-2L for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2015 21:49:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yg1aY-0006XW-Ol for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2015 21:49:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yg1aY-0006XO-Mh for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2015 21:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yg1aY-0004Kr-Ha for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2015 21:49:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Apr 2015 01:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 20276 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 20276@debbugs.gnu.org, monnier@iro.umontreal.ca, gustav@gmail.com Original-Received: via spool by 20276-done@debbugs.gnu.org id=D20276.142854413716636 (code D ref 20276); Thu, 09 Apr 2015 01:49:02 +0000 Original-Received: (at 20276-done) by debbugs.gnu.org; 9 Apr 2015 01:48:57 +0000 Original-Received: from localhost ([127.0.0.1]:49746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yg1aT-0004KG-9m for submit@debbugs.gnu.org; Wed, 08 Apr 2015 21:48:57 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:56309) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yg1aR-0004K4-S5 for 20276-done@debbugs.gnu.org; Wed, 08 Apr 2015 21:48:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgUFAGvvdVRBbthL/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCws0EhQYDSSIE6IRjA0aPQkDAQKDPgMOAQEECINUBKg7 X-IPAS-Result: AgUFAGvvdVRBbthL/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCws0EhQYDSSIE6IRjA0aPQkDAQKDPgMOAQEECINUBKg7 X-IronPort-AV: E=Sophos;i="5.01,1,1400040000"; d="scan'208";a="115765653" Original-Received: from 65-110-216-75.cpe.pppoe.ca (HELO pastel.home) ([65.110.216.75]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Apr 2015 21:48:51 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 058B620AC; Wed, 8 Apr 2015 21:48:49 -0400 (EDT) In-Reply-To: ("Gustav =?UTF-8?Q?H=C3=A5llberg?="'s message of "Thu, 9 Apr 2015 00:38:55 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101313 Archived-At: > git diff also does for what it's worth. Ah, indeed. This doesn't bite us too hard because git also happens to provide the "diff ..." line. > True, but note that diff-font-lock-keywords is more permissive; it does not > require the tab to be present. Of course a false positive in diff-font-lock-keywords will only look funny but won't affect actual behavior, which is why I thought it was OK to be more permissive. Anyway, I guess we have to bite this bullet, so I installed your patch into "master". Thanks, Stefan