Re: [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list

Re: [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list

[Stefan Monnier]

> +  (with-silent-modifications
> +    (let ((inhibit-read-only t))
> +      (dolist (handler yank-handled-properties)
> +	(let ((prop (car handler))
> +	      (fun  (cdr handler))
> +	      (run-start start))
> +	  (while (< run-start end)
> +	    (let ((value (get-text-property run-start prop))
> +		  (run-end (next-single-property-change
> +			    run-start prop nil end)))
> +	      (funcall fun value run-start run-end)

Running the hook functions within with-silent-modifications sounds
dangerous since they may make modifications which shouldn't be ignored
(only the hooks can know).

> +      (if (eq yank-excluded-properties t)
> +	  (set-text-properties start end nil)
> +	(remove-list-of-text-properties start end yank-excluded-properties)))))
 
This is the part that needs to be wrapped.


        Stefan

Re: master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list

[Glenn Morris]

Alan Mackenzie wrote:

> Commit: Alan Mackenzie <acm@muc.de>
>
>     On C-y, stop some text property entries being written into buffer-undo-list
>     
>     lisp/subr.el (remove-yank-excluded-properties): enclose the code in
>     `with-silent-modifications'.


Please include the "* " before the file name in your logs.
Eg use C-c C-a as described in CONTRIBUTE.

Re: [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list

[Alan Mackenzie]

Hello, Stefan.

On Wed, Apr 22, 2015 at 10:34:20AM -0400, Stefan Monnier wrote:
> > +  (with-silent-modifications
> > +    (let ((inhibit-read-only t))
> > +      (dolist (handler yank-handled-properties)
> > +	(let ((prop (car handler))
> > +	      (fun  (cdr handler))
> > +	      (run-start start))
> > +	  (while (< run-start end)
> > +	    (let ((value (get-text-property run-start prop))
> > +		  (run-end (next-single-property-change
> > +			    run-start prop nil end)))
> > +	      (funcall fun value run-start run-end)

> Running the hook functions within with-silent-modifications sounds
> dangerous since they may make modifications which shouldn't be ignored
> (only the hooks can know).

> > +      (if (eq yank-excluded-properties t)
> > +	  (set-text-properties start end nil)
> > +	(remove-list-of-text-properties start end yank-excluded-properties)))))

> This is the part that needs to be wrapped.

Sorry about that.  I've corrected it now.

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list

[Alan Mackenzie]

Hello, Glenn.

On Thu, Apr 23, 2015 at 02:01:02PM -0400, Glenn Morris wrote:
> Alan Mackenzie wrote:

> > Commit: Alan Mackenzie <acm@muc.de>

> >     On C-y, stop some text property entries being written into buffer-undo-list

> >     lisp/subr.el (remove-yank-excluded-properties): enclose the code in
> >     `with-silent-modifications'.


> Please include the "* " before the file name in your logs.
> Eg use C-c C-a as described in CONTRIBUTE.

OK.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list

[Stefan Monnier]

> Sorry about that.  I've corrected it now.

Great, thanks,


        Stefan