all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Alan Mackenzie <acm@muc.de>
Subject: Re: [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list
Date: Wed, 22 Apr 2015 10:34:20 -0400	[thread overview]
Message-ID: <jwvvbgogs0t.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1YkrId-00075y-5s@vcs.savannah.gnu.org> (Alan Mackenzie's message of "Wed, 22 Apr 2015 09:50:31 +0000")

> +  (with-silent-modifications
> +    (let ((inhibit-read-only t))
> +      (dolist (handler yank-handled-properties)
> +	(let ((prop (car handler))
> +	      (fun  (cdr handler))
> +	      (run-start start))
> +	  (while (< run-start end)
> +	    (let ((value (get-text-property run-start prop))
> +		  (run-end (next-single-property-change
> +			    run-start prop nil end)))
> +	      (funcall fun value run-start run-end)

Running the hook functions within with-silent-modifications sounds
dangerous since they may make modifications which shouldn't be ignored
(only the hooks can know).

> +      (if (eq yank-excluded-properties t)
> +	  (set-text-properties start end nil)
> +	(remove-list-of-text-properties start end yank-excluded-properties)))))
 
This is the part that needs to be wrapped.


        Stefan



       reply	other threads:[~2015-04-22 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150422095031.27238.96994@vcs.savannah.gnu.org>
     [not found] ` <E1YkrId-00075y-5s@vcs.savannah.gnu.org>
2015-04-22 14:34   ` Stefan Monnier [this message]
2015-04-25 20:53     ` [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list Alan Mackenzie
2015-04-26  4:11       ` Stefan Monnier
2015-04-23 18:01   ` Glenn Morris
2015-04-25 21:06     ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvbgogs0t.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.