From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Use the new let-opt macro in place of pcase-let in lisp-mode.el Date: Tue, 19 May 2015 22:03:41 -0400 Message-ID: References: <87egmdncf7.fsf@gmail.com> <87oalh6blm.fsf@gmail.com> <874mn956rr.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1432087438 4283 80.91.229.3 (20 May 2015 02:03:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 May 2015 02:03:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Oleh Krehel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 20 04:03:50 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YutMM-00012c-1J for ged-emacs-devel@m.gmane.org; Wed, 20 May 2015 04:03:50 +0200 Original-Received: from localhost ([::1]:49549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YutML-0008RL-2r for ged-emacs-devel@m.gmane.org; Tue, 19 May 2015 22:03:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YutMH-0008RG-BR for emacs-devel@gnu.org; Tue, 19 May 2015 22:03:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YutMD-0004xw-Ue for emacs-devel@gnu.org; Tue, 19 May 2015 22:03:45 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:8668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YutMD-0004xr-RO for emacs-devel@gnu.org; Tue, 19 May 2015 22:03:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgUFAGvvdVTO+LMW/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCwsOJhIUGA0kiBOiEYt2NDoJAwECgz4DDoNiBKNjhFg X-IPAS-Result: AgUFAGvvdVTO+LMW/2dsb2JhbAA3gVOhb4EIgXUBAQQBViMFCwsOJhIUGA0kiBOiEYt2NDoJAwECgz4DDoNiBKNjhFg X-IronPort-AV: E=Sophos;i="5.11,557,1422939600"; d="scan'208";a="121057951" Original-Received: from 206-248-179-22.dsl.teksavvy.com (HELO pastel.home) ([206.248.179.22]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 May 2015 22:03:41 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 47A5E342D; Tue, 19 May 2015 22:03:41 -0400 (EDT) In-Reply-To: <874mn956rr.fsf@gmail.com> (Oleh Krehel's message of "Tue, 19 May 2015 10:08:24 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186639 Archived-At: > (progv (mapcar #'car bindings) > (mapcar (lambda (x) (eval (cadr x))) bindings) > (funcall > `(lambda () > (macroexpand-all > '(progn > ,@body)))))) Hmm? Why this funcall+backquote+lambda business? [ Oh, and be careful to pass macroexpand-all-environment as second arg to macroexpand-all. ] > The code in lisp-mode.el works fine, but there's still one thing on > which I'm not sure: what should happen if an `eval-when-compile' wrapper > is omitted? Same as what happens in your earlier let-opt when the `opt' is omitted. Stefan