* Re: [Emacs-diffs] master bc0b340: A better fix for bug#21739
[not found] ` <E1Zpssa-0007mz-0h@vcs.savannah.gnu.org>
@ 2015-10-24 14:00 ` Stefan Monnier
2015-10-24 14:07 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2015-10-24 14:00 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
> * src/buffer.c (set_update_modelines_for_buf): New function.
> (Fkill_buffer): Use it to set the global variable
> update_mode_lines if the killed buffer was displayed in some
> window. Don't set windows_or_buffers_changed. This is a better
> fix for bug#21739 than the previous fix, since it will cause only
> redisplay of mode lines, not of entire windows, but will still
> catch attention of x_consider_frame_title in xdisp.c, which
> redraws the frame title.
Same question as before: why isn't this caught when the window->buffer
is changed?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Emacs-diffs] master bc0b340: A better fix for bug#21739
2015-10-24 14:00 ` [Emacs-diffs] master bc0b340: A better fix for bug#21739 Stefan Monnier
@ 2015-10-24 14:07 ` Eli Zaretskii
2015-10-24 15:02 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2015-10-24 14:07 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sat, 24 Oct 2015 10:00:43 -0400
>
> > * src/buffer.c (set_update_modelines_for_buf): New function.
> > (Fkill_buffer): Use it to set the global variable
> > update_mode_lines if the killed buffer was displayed in some
> > window. Don't set windows_or_buffers_changed. This is a better
> > fix for bug#21739 than the previous fix, since it will cause only
> > redisplay of mode lines, not of entire windows, but will still
> > catch attention of x_consider_frame_title in xdisp.c, which
> > redraws the frame title.
>
> Same question as before: why isn't this caught when the window->buffer
> is changed?
Because changing a window's buffer only affects that single window.
How's that code to know the frame should be affected?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master bc0b340: A better fix for bug#21739
2015-10-24 14:07 ` Eli Zaretskii
@ 2015-10-24 15:02 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2015-10-24 15:02 UTC (permalink / raw)
To: monnier; +Cc: emacs-devel
> Date: Sat, 24 Oct 2015 17:07:56 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
>
> > From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> > Cc: Eli Zaretskii <eliz@gnu.org>
> > Date: Sat, 24 Oct 2015 10:00:43 -0400
> >
> > > * src/buffer.c (set_update_modelines_for_buf): New function.
> > > (Fkill_buffer): Use it to set the global variable
> > > update_mode_lines if the killed buffer was displayed in some
> > > window. Don't set windows_or_buffers_changed. This is a better
> > > fix for bug#21739 than the previous fix, since it will cause only
> > > redisplay of mode lines, not of entire windows, but will still
> > > catch attention of x_consider_frame_title in xdisp.c, which
> > > redraws the frame title.
> >
> > Same question as before: why isn't this caught when the window->buffer
> > is changed?
>
> Because changing a window's buffer only affects that single window.
> How's that code to know the frame should be affected?
I found a better way of fixing the original problem, see 7a6968b.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-24 15:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151024070435.29886.62731@vcs.savannah.gnu.org>
[not found] ` <E1Zpssa-0007mz-0h@vcs.savannah.gnu.org>
2015-10-24 14:00 ` [Emacs-diffs] master bc0b340: A better fix for bug#21739 Stefan Monnier
2015-10-24 14:07 ` Eli Zaretskii
2015-10-24 15:02 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.