From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 50548fd: cl-fill: Rename arguments to cl-seq and cl-item Date: Sat, 13 Aug 2016 02:06:24 -0400 Message-ID: References: <20160813042949.31299.44303@vcs.savannah.gnu.org> <20160813042950.2B1CB2201C2@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1471125789 9225 195.159.176.226 (13 Aug 2016 22:03:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 Aug 2016 22:03:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Tino Calancha To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 14 00:03:05 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYh1E-0002F1-U1 for ged-emacs-devel@m.gmane.org; Sun, 14 Aug 2016 00:03:05 +0200 Original-Received: from localhost ([::1]:58672 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYh1C-0002Dh-2m for ged-emacs-devel@m.gmane.org; Sat, 13 Aug 2016 18:03:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYh15-0002Cc-5g for emacs-devel@gnu.org; Sat, 13 Aug 2016 18:02:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYh10-0006dL-Vt for emacs-devel@gnu.org; Sat, 13 Aug 2016 18:02:54 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:9982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYh10-0006dH-SZ for emacs-devel@gnu.org; Sat, 13 Aug 2016 18:02:50 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BZBgCJI6tX/9+cs2tdGgEBAQGDJ1Z8gnmFUIRkq3mBdAkZC4VzBAICgV05FAEBAQEBAQFdJ4RfAQEBAgEBAQFTGAsFCws0EhQTAQQNN4gpCA7BTgEBAQEBAQQCAR8FineFDIUPBZk8hh2FQox6hXyQLB42gkWBUSAyhywBAQE X-IPAS-Result: A0BZBgCJI6tX/9+cs2tdGgEBAQGDJ1Z8gnmFUIRkq3mBdAkZC4VzBAICgV05FAEBAQEBAQFdJ4RfAQEBAgEBAQFTGAsFCws0EhQTAQQNN4gpCA7BTgEBAQEBAQQCAR8FineFDIUPBZk8hh2FQox6hXyQLB42gkWBUSAyhywBAQE X-IronPort-AV: E=Sophos;i="5.28,500,1464667200"; d="scan'208";a="253022325" Original-Received: from 107-179-156-223.cpe.teksavvy.com (HELO pastel.home) ([107.179.156.223]) by smtp.teksavvy.com with ESMTP; 13 Aug 2016 18:02:47 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 59BEB64E2A; Sat, 13 Aug 2016 02:06:24 -0400 (EDT) In-Reply-To: <20160813042950.2B1CB2201C2@vcs.savannah.gnu.org> (Tino Calancha's message of "Sat, 13 Aug 2016 04:29:50 +0000 (UTC)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206597 Archived-At: > cl-fill: Rename arguments to cl-seq and cl-item Why? The "cl-" prefix is for global vars. It used to be used "everywhere" for local vars as well because dynamic binding made the local vars visible in other scopes as well, but nowadays that CL uses lexical-binding this should not be needed any more and the tendency is rather to eliminate use of the "cl-" prefix for args and local vars. Stefan > * lisp/emacs-lisp/cl-seq.el (cl-fill): > Rename arguments to 'cl-seq' and 'cl-item' as elsewhere. > --- > lisp/emacs-lisp/cl-seq.el | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > diff --git a/lisp/emacs-lisp/cl-seq.el b/lisp/emacs-lisp/cl-seq.el > index 98e5f4e..ed27b7c 100644 > --- a/lisp/emacs-lisp/cl-seq.el > +++ b/lisp/emacs-lisp/cl-seq.el > @@ -144,24 +144,24 @@ called. > cl-accum))) > ;;;###autoload > -(defun cl-fill (seq item &rest cl-keys) > +(defun cl-fill (cl-seq cl-item &rest cl-keys) > "Fill the elements of SEQ with ITEM. > \nKeywords supported: :start :end > \n(fn SEQ ITEM [KEYWORD VALUE]...)" > (cl--parsing-keywords ((:start 0) :end) () > - (if (listp seq) > - (let ((p (nthcdr cl-start seq)) > + (if (listp cl-seq) > + (let ((p (nthcdr cl-start cl-seq)) > (n (if cl-end (- cl-end cl-start) 8000000))) > (while (and p (>= (setq n (1- n)) 0)) > - (setcar p item) > + (setcar p cl-item) > (setq p (cdr p)))) > - (or cl-end (setq cl-end (length seq))) > - (if (and (= cl-start 0) (= cl-end (length seq))) > - (fillarray seq item) > + (or cl-end (setq cl-end (length cl-seq))) > + (if (and (= cl-start 0) (= cl-end (length cl-seq))) > + (fillarray cl-seq cl-item) > (while (< cl-start cl-end) > - (aset seq cl-start item) > + (aset cl-seq cl-start cl-item) > (setq cl-start (1+ cl-start))))) > - seq)) > + cl-seq)) > ;;;###autoload > (defun cl-replace (cl-seq1 cl-seq2 &rest cl-keys) > _______________________________________________ > Emacs-diffs mailing list > Emacs-diffs@gnu.org > https://lists.gnu.org/mailman/listinfo/emacs-diffs