From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#22983: [ Patch ] Re: bug#22983: syntax-ppss returns wrong result. Date: Sun, 10 Sep 2017 18:53:53 -0400 Message-ID: References: <9fc66395-045c-1984-f530-033c2ff706f6@yandex.ru> <83h8wlz1kf.fsf@gnu.org> <20170902174027.GB4267@ACM> <20170907204502.GC4488@ACM> <69e034d3-7a52-cc81-dc56-e5308ad5dce0@yandex.ru> <20170910113626.GB3588@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505084060 23045 195.159.176.226 (10 Sep 2017 22:54:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 10 Sep 2017 22:54:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: John Wiegley , Philipp Stephani , Dmitry Gutov , 22983@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 11 00:54:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drB77-0005Hf-Uz for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 00:54:06 +0200 Original-Received: from localhost ([::1]:54541 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drB7F-0004xy-4j for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 18:54:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drB77-0004xr-CR for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 18:54:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drB74-00064e-A3 for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 18:54:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51252) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drB74-00064W-6M for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 18:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drB73-00044W-S7 for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 18:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2017 22:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22983-submit@debbugs.gnu.org id=B22983.150508403715641 (code B ref 22983); Sun, 10 Sep 2017 22:54:01 +0000 Original-Received: (at 22983) by debbugs.gnu.org; 10 Sep 2017 22:53:57 +0000 Original-Received: from localhost ([127.0.0.1]:59933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drB6z-00044C-EY for submit@debbugs.gnu.org; Sun, 10 Sep 2017 18:53:57 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drB6x-000444-L2 for 22983@debbugs.gnu.org; Sun, 10 Sep 2017 18:53:56 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v8AMrre9010349; Sun, 10 Sep 2017 18:53:54 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id A6873661FA; Sun, 10 Sep 2017 18:53:53 -0400 (EDT) In-Reply-To: <20170910113626.GB3588@ACM> (Alan Mackenzie's message of "Sun, 10 Sep 2017 11:36:26 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6112=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6112> : inlines <6061> : streams <1762466> : uri <2498304> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136752 Archived-At: > +;; Several caches. > +;; Because `syntax-ppss' is equivalent to (parse-partial-sexp > +;; (POINT-MIN) x), we need either to empty the cache when we narrow > +;; the buffer, which is suboptimal, or we need to use several caches. I think that (parse-partial-sexp 1 x) is more often what the caller wants than (parse-partial-sexp (point-min) x), but if you're happy with the behavior described by the docstring, then that's fine. > +;; The implementation which follows uses three caches, the current one > +;; (in `syntax-ppss-cache' and `syntax-ppss-last') and two inactive > +;; ones (in `syntax-ppss-{cache,last}-{wide,narrow}'), which store the > +;; former state of the active cache as it was used in widened and > +;; narrowed buffers respectively. Earlier in the thread, I suggested to use a single cache indexed by the position of point-min (or by the position and point-min and by the current syntax-table, so as to also handle changes in the syntax-table), i.e. a list of (POINT-MIN-POS . CACHE-DATA) or ((POINT-MIN-POS . SYNTAX-TABLE) . CACHE-DATA). I think it would lead to less code duplication than your patch which only handles 2 different POINT-MIN-POS (and one of the two has to be equal to 1), but existing code trumps hypothetical designs. So, I have no objections to the patch. But I think (parse-partial-sexp (point-min) x) is a design bug in syntax-ppss which we will need to fix sooner or later, which is why I never bothered to implement something like your patch, which only makes the code do what its doc says rather than what the caller needs. Stefan