all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: emacs-26 9e59de9: Use GCALIGNED properly for GCC
Date: Fri, 10 Nov 2017 11:23:40 -0500	[thread overview]
Message-ID: <jwvvaiiyv6z.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 83shdmpiah.fsf@gnu.org

>   union gcaligned_foo { struct foo s; int64_t gcaligned; };

Are int64_t necessarily aligned on multiples of 8 on 32bit platforms?

> IOW, should we rely on alignas?  There could be dragons there too, no?

FWIW, for the dummy alignment thingy I wouldn't use `char` (I wouldn't be
surprised to see errors in compilers when asking to align on multiples
of N for objects smaller than N), so maybe

    #define gc_aligned(typename) \
       union { typename s; int64_t alignas (GCALIGNMENT) dummy; };

I'm not super happy about the "64" in there (which hardcodes basically
the value of GCALIGNMENT).  Depending on how alignas can be used to
impose alignment of an array, we could try:

    typedef char gcsized_t[GCALIGNMENT];
    #define gc_aligned(typename) \
       union { typename s; gcsized_t alignas (GCALIGNMENT) dummy; }

but maybe getting rid of this 64 is not that important.


        Stefan




  reply	other threads:[~2017-11-10 16:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20171109031206.7056.28312@vcs0.savannah.gnu.org>
     [not found] ` <20171109031208.D2CAF2033E@vcs0.savannah.gnu.org>
2017-11-09 23:31   ` emacs-26 9e59de9: Use GCALIGNED properly for GCC Glenn Morris
2017-11-10  7:10     ` martin rudalics
2017-11-10  8:06       ` Eli Zaretskii
2017-11-10  8:26         ` Paul Eggert
2017-11-10  9:57           ` Eli Zaretskii
2017-11-10 16:23             ` Stefan Monnier [this message]
2017-11-10 17:58               ` Paul Eggert
2017-11-10 18:02                 ` Stefan Monnier
2017-11-10 18:11                   ` Philipp Stephani
2017-11-10 19:19                     ` Paul Eggert
2017-11-10 20:31                       ` Stefan Monnier
2017-11-10 20:45                         ` Paul Eggert
2017-11-11  7:08           ` Paul Eggert
2017-11-11  7:57             ` Paul Eggert
2017-11-11  8:34               ` martin rudalics
2017-11-11  8:50                 ` Paul Eggert
2017-11-11  9:46                   ` martin rudalics
2017-11-11  8:33             ` martin rudalics
2017-11-13 18:19               ` Paul Eggert
2017-11-13 18:45                 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvaiiyv6z.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.