From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Lisp primitives and their calling of the change hooks Date: Wed, 03 Jan 2018 16:51:29 -0500 Message-ID: References: <20180103124543.GA5435@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515016541 14881 195.159.176.226 (3 Jan 2018 21:55:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 3 Jan 2018 21:55:41 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 03 22:55:37 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWr0Z-0003UO-AA for ged-emacs-devel@m.gmane.org; Wed, 03 Jan 2018 22:55:35 +0100 Original-Received: from localhost ([::1]:38575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWr2Y-0006qS-94 for ged-emacs-devel@m.gmane.org; Wed, 03 Jan 2018 16:57:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWqwz-0002bp-BX for emacs-devel@gnu.org; Wed, 03 Jan 2018 16:51:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWqww-0005z5-P4 for emacs-devel@gnu.org; Wed, 03 Jan 2018 16:51:53 -0500 Original-Received: from [195.159.176.226] (port=37073 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWqww-0005yO-Hq for emacs-devel@gnu.org; Wed, 03 Jan 2018 16:51:50 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eWquu-0007cD-F6 for emacs-devel@gnu.org; Wed, 03 Jan 2018 22:49:44 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:X3KJ4ZY6WpIS7HdMaPbgi3+addo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221563 Archived-At: > 6. Write and run a script which executes each of these primitives whilst > counting the number of times it invokes before-change-hooks and > after-change-hooks. FWIW, we do not try to make those numbers match (and their begin/end specs don't necessarily match either). What we aim to do (i.e. what defines what I would consider as a bug) is to make sure every a-c-f is preceded by a "covering" b-c-f. IOW, b-c-f may be followed by any number of a-f-c (including 0) as long as those are within the text chunk covered by the b-f-c. Some of your results clearly indicate what I'd consider as bugs. E.g. `erase-buffer` should call those hooks (unless the buffer was already empty). OTOH for upcase-region 1 call to b-c-f and 0 to a-c-f is acceptable. For most of the others, a deeper inspection would be needed to figure out if there's an actual bug or if it's just a normal occurrence. Stefan