From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom. Date: Wed, 21 Feb 2018 17:04:49 -0500 Message-ID: References: <20180221213025.27066.69339@vcs0.savannah.gnu.org> <20180221213027.372932052F@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519250723 17789 195.159.176.226 (21 Feb 2018 22:05:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Feb 2018 22:05:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Juri Linkov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 21 23:05:19 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eocVq-0004LP-Om for ged-emacs-devel@m.gmane.org; Wed, 21 Feb 2018 23:05:18 +0100 Original-Received: from localhost ([::1]:34967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eocXs-00087A-OJ for ged-emacs-devel@m.gmane.org; Wed, 21 Feb 2018 17:07:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eocWU-000827-VW for emacs-devel@gnu.org; Wed, 21 Feb 2018 17:06:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eocVQ-0005dj-KW for emacs-devel@gnu.org; Wed, 21 Feb 2018 17:05:58 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:33034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eocVP-0005b0-W5 for emacs-devel@gnu.org; Wed, 21 Feb 2018 17:04:52 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w1LM4nO9026921; Wed, 21 Feb 2018 17:04:50 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 81103663FA; Wed, 21 Feb 2018 17:04:49 -0500 (EST) In-Reply-To: <20180221213027.372932052F@vcs0.savannah.gnu.org> (Juri Linkov's message of "Wed, 21 Feb 2018 16:30:26 -0500 (EST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6227=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6227> : inlines <6423> : streams <1779659> : uri <2597022> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222971 Archived-At: > +(defcustom next-error-find-buffer-function nil Why make it a defcustom rather than a defvar? > + (when next-error-find-buffer-function > + (funcall next-error-find-buffer-function avoid-current > + extra-test-inclusive > + extra-test-exclusive)) Could you arrange for the default value of this new *-function var not to be nil so we can modify it with add-function? Stefan