From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Message's text-properties in *Messages* Date: Wed, 30 May 2018 22:09:50 -0400 Message-ID: References: <20180521171019.GA5750@ACM> <83a7sqcmnw.fsf@gnu.org> <83603eckk6.fsf@gnu.org> <83tvqpgix5.fsf@gnu.org> <83po1chqat.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1527732477 11594 195.159.176.226 (31 May 2018 02:07:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 31 May 2018 02:07:57 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 31 04:07:53 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fOD0K-0002s6-RO for ged-emacs-devel@m.gmane.org; Thu, 31 May 2018 04:07:52 +0200 Original-Received: from localhost ([::1]:41565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOD2Q-0006Dv-50 for ged-emacs-devel@m.gmane.org; Wed, 30 May 2018 22:10:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOD2J-0006Do-FB for emacs-devel@gnu.org; Wed, 30 May 2018 22:09:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fOD2G-0000ik-A0 for emacs-devel@gnu.org; Wed, 30 May 2018 22:09:55 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:48116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fOD2G-0000iH-40; Wed, 30 May 2018 22:09:52 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w4V29oIr001051; Wed, 30 May 2018 22:09:50 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 2718B660DF; Wed, 30 May 2018 22:09:50 -0400 (EDT) In-Reply-To: <83po1chqat.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 May 2018 22:55:06 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6297=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6297> : inlines <6667> : streams <1788288> : uri <2650008> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225836 Archived-At: >> > As I wrote previously, redisplay is not the issue here, as >> > message_dolog doesn't call any redisplay entry points. >> Hmm... indeed I'm not worried about message_dolog calling redisplay, >> instead I think the worry is about redisplay calling message_dolog >> (probably via `message` or some variant thereof). > > I don't think this happens, and I don't think it could work for > redisplay to call 'message' or its ilk. Do you see any such calls? I haven't checked: I just assumed it was part of the worry. BTW now I see that message_dolog indeed runs the after-change-functions as well, so it already runs arbitrary Lisp code (and if its after-change-functions call `message` you get funny results). >> And in that case, we could also replace message_dolog with >> message_dolog_lisp (if needed, building a fresh new Lisp string from >> a char*). > Probably, although it could be cumbersome with some of the current > callers. I'll see how it comes out, Stefan