all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Federico Tedin <federicotedin@gmail.com>
Cc: martin rudalics <rudalics@gmx.at>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 134ba45: Allow two mouse functions to work with Rectangle Mark mode
Date: Fri, 26 Oct 2018 13:25:25 -0400	[thread overview]
Message-ID: <jwvva5ofx0n.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <CAA8GjPnCf1WGs6gR_vCedff-K04eL5WbQqK4BHxSeSFbwRbOMw@mail.gmail.com> (Federico Tedin's message of "Thu, 25 Oct 2018 20:24:28 -0300")

> Stefan, I've prepared a patch that fixes most of the problems you
> found with my commit.

Thanks, installed (after changing text-property-any with
text-property-not-all so we also detect non-t non-nil values as meaning
"read-only").

> Although this patch tidies up mouse-drag-and-drop-region, the problem
> of always treating noncontiguous regions as rectangles still remains.
> I have limited experience writing Emacs Lisp so I am not sure what the
> options are to solve this, but I'm interested in participating in the
> process of thinking/implementing a solution.

AFAICT the next step is to introduce a function `reactivate-mark`.
This function will need to know what kind of mark was earlier activated,
so we will need to store the "kind of mark" somewhere.
I guess the easiest is to introduce a new var
`reactivate-mark-function` (so reactivate-mark doesn't need to do much
more than funcall it).

Then we'll want to change a few places in Elisp to set/reset this var.


        Stefan



  reply	other threads:[~2018-10-26 17:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181017063829.3775.67018@vcs0.savannah.gnu.org>
     [not found] ` <20181017063831.03DCB2044D@vcs0.savannah.gnu.org>
2018-10-17 15:47   ` [Emacs-diffs] master 134ba45: Allow two mouse functions to work with Rectangle Mark mode Stefan Monnier
2018-10-17 16:17     ` Drew Adams
2018-10-19 15:24       ` Stefan Monnier
2018-10-20  3:21         ` Federico Tedin
2018-10-20  3:48           ` Stefan Monnier
2018-10-20 20:21             ` Federico Tedin
2018-10-20 20:56               ` Federico Tedin
2018-10-20 21:21               ` Stefan Monnier
2018-10-21  8:22                 ` martin rudalics
2018-10-22 13:04                   ` Federico Tedin
2018-10-25 23:24                     ` Federico Tedin
2018-10-26 17:25                       ` Stefan Monnier [this message]
2018-10-26 22:07                         ` Federico Tedin
2018-10-28  0:30                           ` Stefan Monnier
2018-10-29 23:40                             ` Federico Tedin
2018-10-30 12:52                               ` Stefan Monnier
2019-01-07 17:40                               ` Stefan Monnier
2019-01-26 21:58                                 ` Federico Tedin
2019-01-28  9:12                                   ` Stefan Monnier
2019-01-29  4:02                                     ` Federico Tedin
2019-01-29  9:28                                       ` Stefan Monnier
2019-01-30  3:39                                         ` Federico Tedin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvva5ofx0n.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=federicotedin@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.