From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use closures in hashcash.el Date: Tue, 12 Mar 2019 16:37:30 -0400 Message-ID: References: <20190312031247.clqdquwuempidmt3@nullprogram.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38244"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Christopher Wellons To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 12 21:45:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3oHG-0009lW-B9 for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2019 21:45:34 +0100 Original-Received: from localhost ([127.0.0.1]:33065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3oHF-00053i-3u for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2019 16:45:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3oFv-0004dd-EO for emacs-devel@gnu.org; Tue, 12 Mar 2019 16:44:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3o9u-0004RR-9X for emacs-devel@gnu.org; Tue, 12 Mar 2019 16:37:58 -0400 Original-Received: from [195.159.176.226] (port=46348 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3o9u-0004DJ-0D for emacs-devel@gnu.org; Tue, 12 Mar 2019 16:37:58 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h3o9Z-0000Nt-Jx for emacs-devel@gnu.org; Tue, 12 Mar 2019 21:37:37 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:AKWMhP1+UH6dnWfJGcKL/+mjq4I= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234117 Archived-At: > hashcash.el was switched over to lexical scope in da94ea9, but it still > uses an old workaround of dynamically constructing lambda expression > "closures" using backquote. The following patch changes these into > proper closures. Thanks, installed with the change below: > - (set-process-filter process `(lambda (process output) > - (funcall ,callback process output)))) > + (set-process-filter process (lambda (process output) > + (funcall callback process output)))) Actually, this lambda expression is just a roundabout way to say `callback` (by η-reduction). Stefan