From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Use of minibuffer-prompt face when minibuffer is not involved Date: Fri, 10 May 2019 16:52:46 -0400 Message-ID: References: <8736lmi2dg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="107003"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 10 22:53:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPCVy-000Ren-UA for ged-emacs-devel@m.gmane.org; Fri, 10 May 2019 22:53:11 +0200 Original-Received: from localhost ([127.0.0.1]:49811 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPCVx-0002TT-S0 for ged-emacs-devel@m.gmane.org; Fri, 10 May 2019 16:53:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPCVk-0002RR-K2 for emacs-devel@gnu.org; Fri, 10 May 2019 16:52:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPCVj-0005G4-Op for emacs-devel@gnu.org; Fri, 10 May 2019 16:52:56 -0400 Original-Received: from [195.159.176.226] (port=48666 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hPCVj-0005Df-GE for emacs-devel@gnu.org; Fri, 10 May 2019 16:52:55 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hPCVh-000RGN-7p for emacs-devel@gnu.org; Fri, 10 May 2019 22:52:53 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:tWqfj4WgE8kncyOSXI9tjjWGYGw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236393 Archived-At: > 0. Do nothing. ("The face might be called minibuffer-prompt, but there > are enough non-minibuffer uses of it that it's not worth fixing > this inconsistency at this point.") That's what I vote for. More to the point, I think the difference between minibuffer prompts and non-minibuffer prompts should be a purely internal one. After all, you could rewrite yes-or-no-p so as not to use a minibuffer or rewrite y-or-n-p to make it use a minibuffer: should that have as a side-effect to use a different face, really? > - dired-do-shell-command's warning about "wildcard" characters > annoys me, since AFAICT they may not be wildcards at all > (e.g. they may be quoted or backslash-escaped). > > - Rather than coming up with a better warning, I toyed with text > properties to build a prompt which highlights these characters. > > - I found out that y-or-n-p discards my prompt's text properties. So the problem is not the use of minibuffer-prompt but the fact that it overrides other faces while applying it. That should be easy to fix by using `add-face-text-property` instead of `propertize`. Stefan