From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Use of minibuffer-prompt face when minibuffer is not involved
Date: Fri, 10 May 2019 16:52:46 -0400 [thread overview]
Message-ID: <jwvv9yi9grv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: 8736lmi2dg.fsf@gmail.com
> 0. Do nothing. ("The face might be called minibuffer-prompt, but there
> are enough non-minibuffer uses of it that it's not worth fixing
> this inconsistency at this point.")
That's what I vote for.
More to the point, I think the difference between minibuffer prompts and
non-minibuffer prompts should be a purely internal one. After all, you
could rewrite yes-or-no-p so as not to use a minibuffer or rewrite
y-or-n-p to make it use a minibuffer: should that have as a side-effect
to use a different face, really?
> - dired-do-shell-command's warning about "wildcard" characters
> annoys me, since AFAICT they may not be wildcards at all
> (e.g. they may be quoted or backslash-escaped).
>
> - Rather than coming up with a better warning, I toyed with text
> properties to build a prompt which highlights these characters.
>
> - I found out that y-or-n-p discards my prompt's text properties.
So the problem is not the use of minibuffer-prompt but the fact that it
overrides other faces while applying it. That should be easy to fix by
using `add-face-text-property` instead of `propertize`.
Stefan
next prev parent reply other threads:[~2019-05-10 20:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 18:35 Use of minibuffer-prompt face when minibuffer is not involved Kévin Le Gouguec
2019-05-10 20:52 ` Stefan Monnier [this message]
2019-05-10 21:59 ` Drew Adams
2019-05-10 22:36 ` Stefan Monnier
2019-05-11 6:25 ` Eli Zaretskii
2019-05-11 13:22 ` Kévin Le Gouguec
[not found] ` <<jwvftpm9buh.fsf-monnier+emacs@gnu.org>
[not found] ` <<83o949ecdc.fsf@gnu.org>
2019-05-11 13:52 ` Drew Adams
2019-05-11 14:11 ` Eli Zaretskii
2019-05-12 22:31 ` Richard Stallman
2019-05-12 23:32 ` Drew Adams
[not found] ` <<<jwvftpm9buh.fsf-monnier+emacs@gnu.org>
[not found] ` <<<83o949ecdc.fsf@gnu.org>
[not found] ` <<c7e501bb-9dd8-4b00-8647-d0731f2b2565@default>
[not found] ` <<83o949cc88.fsf@gnu.org>
2019-05-11 14:34 ` Drew Adams
2019-05-11 13:50 ` Solving bug#35564 (was: Use of minibuffer-prompt face when minibuffer is not involved) Kévin Le Gouguec
2019-05-11 14:13 ` Solving bug#35564 Stefan Monnier
[not found] <<<8736lmi2dg.fsf@gmail.com>
[not found] <<8736lmi2dg.fsf@gmail.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvv9yi9grv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.