From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change Date: Tue, 01 Oct 2019 17:30:38 -0400 Message-ID: References: <20191001144135.32717.19241@vcs0.savannah.gnu.org> <20191001144137.1032C20927@vcs0.savannah.gnu.org> <87tv8s32zi.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="74915"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 01 23:51:31 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFQ3O-000JOe-PI for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2019 23:51:30 +0200 Original-Received: from localhost ([::1]:48590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFQ3L-0003La-NX for ged-emacs-devel@m.gmane.org; Tue, 01 Oct 2019 17:51:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37862) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFPjJ-0008MJ-CL for emacs-devel@gnu.org; Tue, 01 Oct 2019 17:30:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFPjI-0004hJ-2b for emacs-devel@gnu.org; Tue, 01 Oct 2019 17:30:44 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18311) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFPjH-0004h5-Sx for emacs-devel@gnu.org; Tue, 01 Oct 2019 17:30:44 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DE83784F38; Tue, 1 Oct 2019 17:30:41 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 842BD811B8; Tue, 1 Oct 2019 17:30:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1569965440; bh=PC3d1s9P6welzgqpr1MjOkF227Hz4Wv7B7TIpJ99UtU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QSBSDPLkA3bjufYRe2VHWazmaaPt7oyDy9MZf0rli1rS0hYsHb7u0AYKXozFUv8Lf lTNbA20zEtMk1oQwPKIMJNpUmsbCYH3u8+LqzpdQlls+ZYUJOy9A/8pKlES47qxPh2 yK9X9rngB5Iqoep1SE/mDMwK9TYGQMBNsEhbK7fwMhjS1awIuy4+GicujxWIdVw1pI J/A1275fftdzPqdGD4KpTyeqXp2tMGAODCXl/C2iorNzqQRJphxpNzoeOx8XZnYBDc /mGVLIeWOGF/ixu2Yzujg8AtVhHucKebeb/633gI1zFMgMC8y+yAsrIPsfEvZqlgjn kpouzmSbZsXDA== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 54A9A1209FB; Tue, 1 Oct 2019 17:30:40 -0400 (EDT) In-Reply-To: <87tv8s32zi.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Oct 2019 17:22:09 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240447 Archived-At: > I'm not quite sure I followed the last bit -- if something transitively > required cl-lib, then there's no point for the "top" file to require > cl-lib, surely? Or is this a style issue. If a file (transitively) required by bytecomp.el requires cl-lib, then when compiling *another* file any missing (require 'cl-lib) in that other file won't be noticed. > (defvar emacs-lisp-compilation-mode-map > (let ((map (make-sparse-keymap))) > (set-keymap-parent map compilation-minor-mode-map) > (define-key map "g" 'emacs-lisp-compilation-recompile) > map)) Do we need this set-keymap-parent? define-derived-mode should do it for us (when the mode is called). Stefan