From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Wed, 05 Feb 2020 09:46:23 -0500 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="80233"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38992@debbugs.gnu.org, Dmitry Gutov , joaotavora@gmail.com, waah@yellowfrog.io To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 05 15:47:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1izLxV-000Klk-K3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Feb 2020 15:47:17 +0100 Original-Received: from localhost ([::1]:48510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izLxU-0003XY-MG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Feb 2020 09:47:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35200) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izLxH-0003Vc-8P for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 09:47:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izLxG-0006Vl-B1 for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 09:47:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39326) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1izLxG-0006Vg-7w for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 09:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1izLxG-0004nJ-7P for bug-gnu-emacs@gnu.org; Wed, 05 Feb 2020 09:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Feb 2020 14:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158091399317094 (code B ref 38992); Wed, 05 Feb 2020 14:47:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 5 Feb 2020 14:46:33 +0000 Original-Received: from localhost ([127.0.0.1]:45293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLwm-0004RO-QK for submit@debbugs.gnu.org; Wed, 05 Feb 2020 09:46:33 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izLwl-0004MV-LA for 38992@debbugs.gnu.org; Wed, 05 Feb 2020 09:46:32 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2D01044B021; Wed, 5 Feb 2020 09:46:26 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9E22244B01D; Wed, 5 Feb 2020 09:46:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580913984; bh=40BAzjoWVou+cyoCW9hobgTx3jU0ZYBQA9jkOe0/N98=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mKsT9oYYS2hoaMb82CPOQEOBwqUZkfutZXd3aKhXgE7OdLFmaADeKr4CKaJBw9yPZ DAMNwQN7Zlj8KmW55KC/j8lbK5lnOAdAQu/uuPQYeVq+iwvEMuwN2LPHTCfqW+Vebk pa2HRWmcU/WcExFDs6co7WBIFc9MDcl5Tih9IfHqNgEggGP9C/kHcoGt/stHaCAtdZ mXpropH4H2yjwEn93Wo4aF/HyYJ/75fyo7FT3jGiQKdJ143R7AVENJkuvdNXp+Rn0i +wi9WerzajNs9I8jAZjTQUrQXd7hLS/eXtGmZHjQX8ju7I6pEuKTKmTdk5jImCTT6Z ggaIix2OezxQg== Original-Received: from pastel (unknown [216.154.34.88]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3163612037A; Wed, 5 Feb 2020 09:46:24 -0500 (EST) In-Reply-To: <838slhglog.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Feb 2020 16:20:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175700 Archived-At: >> And the first one makes a lot of sense (no need to invent an extra >> variable if the way to store the necessary info is so obvious). > I didn't say it didn't make sense. The only issue that worries me is > how safe it is for the release branch. Agreed. > I have no issues whatsoever with making these changes on master. Right: the change to `minibuffer-completion-confirm` is for `master`. For the release branch we should either find some workaround or just leave things as they are. Stefan