From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: 40570@debbugs.gnu.org
Subject: bug#40570: [PATCH] Alias cl-subseq to seq-subseq, define gv-setter in the latter
Date: Sun, 12 Apr 2020 12:18:15 -0400 [thread overview]
Message-ID: <jwvv9m4r8l6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20200412094627.2494060-1-stepnem@gmail.com> ("Štěpán Němec"'s message of "Sun, 12 Apr 2020 11:46:27 +0200")
> The definition was moved in
>
> 2019-10-27T13:25:00-04:00!monnier@iro.umontreal.ca
> 0e4dd67aae (* lisp/emacs-lisp/seq.el: Don't require cl-lib.)
>
> already, but not the gv-setter declaration, so 'setf' worked with
> 'cl-subseq', but not with 'seq-subseq'.
Indeed, when I made the move I just wanted to change the implementation
but not the featureset (AFAIK seq-subseq never supported `setf`).
So this bug report is fundamentally a feature request: make `seq-subseq`
into a (gv) generalized variable.
> --- a/lisp/emacs-lisp/seq.el
> +++ b/lisp/emacs-lisp/seq.el
> @@ -154,6 +154,11 @@ seq-subseq
> START or END is negative, it counts from the end. Signal an
> error if START or END are outside of the sequence (i.e too large
> if positive or too small if negative)."
> + (declare (gv-setter
> + (lambda (new)
> + (macroexp-let2 nil new new
> + `(progn (cl-replace ,sequence ,new :start1 ,start :end1 ,end)
> + ,new)))))
The main purpose of the move was to reverse the order of dependency so
that `cl-lib` would depend on `seq` rather than the reverse.
This implies that `seq` shouldn't use `cl-lib`. The above `cl-replace`
is hence problematic.
Another issue is that `seq-subseq` is a generic function, so its
gv-setter should also use generic functions so that it can also be made
to work on other sequence types than the predefined ones.
IOW we should probably introduce a new `seq` generic function which does
something similar to `cl-replace`, then make `seq-subseq` use it in its
gv-setter, and ideally also make `cl-replace` use it ;-)
Stefan
next prev parent reply other threads:[~2020-04-12 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 9:46 bug#40570: [PATCH] Alias cl-subseq to seq-subseq, define gv-setter in the latter Štěpán Němec
2020-04-12 16:18 ` Stefan Monnier [this message]
2020-04-12 17:16 ` Štěpán Němec
2020-04-12 19:18 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvv9m4r8l6.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=40570@debbugs.gnu.org \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.