From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 188bd80: gnus-shorten-url: Improve and avoid args-out-of-range error Date: Mon, 13 Apr 2020 12:51:58 -0400 Message-ID: References: <20200413102415.23314.52412@vcs0.savannah.gnu.org> <20200413102417.445E520D0C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="88070"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 13 18:52:44 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jO2KA-000MnN-CD for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Apr 2020 18:52:42 +0200 Original-Received: from localhost ([::1]:46590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jO2K9-0007x6-Ar for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Apr 2020 12:52:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37131) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jO2Jd-0007Xk-U7 for emacs-devel@gnu.org; Mon, 13 Apr 2020 12:52:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jO2Jc-00056z-D8 for emacs-devel@gnu.org; Mon, 13 Apr 2020 12:52:09 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11967) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jO2Jc-00056a-7W for emacs-devel@gnu.org; Mon, 13 Apr 2020 12:52:08 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E8AA1810AF; Mon, 13 Apr 2020 12:52:06 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C6C7480D6C; Mon, 13 Apr 2020 12:52:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1586796724; bh=NPXvbZVJqpiOB02JVD+jxc4JYT3DPd/QyAM2O62Cf6U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MjNAnp2nPKgHPOL1WfsFy6Dg6AkNt8ZpNZscbeXLKM+FKoGWQqBZSxa5JPBYMKRkb CyVFJBMqcqf1NCQFecabBmLF5oRzjcXiiLvRghP1TYYi3jA6yG59PAy3+UE+HNThZQ 2YY/1iD2c7F8BzmPfnrhrBk4xZ/MAON/4ho9k4BCB7TBrror89wzJW9fB2zNQu8FPt SYiAeOe3Kb7AStlOeg1umPpv3W4NutKdB4kUtcnFtD9FGU2BBpLIUnBXKUDWFjrPFo vIWqp3zgN4ghikAlz7OXO22Wa+5zIL9SBpDhjh2YXPgX5PTJTeI3yLFyXQd3BWWxa/ JfQHZWsC5+rKw== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 98A2D1203FD; Mon, 13 Apr 2020 12:52:04 -0400 (EDT) In-Reply-To: <20200413102417.445E520D0C@vcs0.savannah.gnu.org> (=?utf-8?B?IumWoz9w55aj?= N?mec"'s message of "Mon, 13 Apr 2020 06:24:16 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246917 Archived-At: > +;;;###autoload > +(defun string-truncate-left (string length) > + "Truncate STRING to LENGTH, replacing initial surplus with \"...\"." > + (let ((strlen (length string))) > + (if (<= strlen length) > + string > + (setq length (max 0 (- length 3))) > + (concat "..." (substring string (max 0 (- strlen 1 length))))))) This should of course rely on string-width rather than string-length, but more importantly, it should obey `truncate-string-ellipsis` and it should be "closer" to `truncate-string-to-width` (they should likely be in the same file, and with similar sounding names). Maybe it should even be merged with `truncate-string-to-width`. Stefan