From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52092: 28.0.60; hs-toggle-hiding does not toggle once folded Date: Fri, 23 Sep 2022 18:01:05 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5401"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52092@debbugs.gnu.org, Eli Zaretskii , Mohammed Sadiq To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 24 00:05:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obqnc-0001Da-Fa for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Sep 2022 00:05:32 +0200 Original-Received: from localhost ([::1]:42074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obqna-00018U-VY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Sep 2022 18:05:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obqkG-00068F-4u for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 18:02:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obqkE-0001Kk-Gl for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 18:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1obqkE-0000s4-11 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 18:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2022 22:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: help Original-Received: via spool by 52092-submit@debbugs.gnu.org id=B52092.16639704753293 (code B ref 52092); Fri, 23 Sep 2022 22:02:01 +0000 Original-Received: (at 52092) by debbugs.gnu.org; 23 Sep 2022 22:01:15 +0000 Original-Received: from localhost ([127.0.0.1]:41873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obqjS-0000r3-PT for submit@debbugs.gnu.org; Fri, 23 Sep 2022 18:01:15 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obqjR-0000qq-NY for 52092@debbugs.gnu.org; Fri, 23 Sep 2022 18:01:14 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0528F1000EF; Fri, 23 Sep 2022 18:01:08 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2F8E9100169; Fri, 23 Sep 2022 18:01:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1663970466; bh=t/Q4U0xkYze3uqdfftIvLr//maI74hiPCwblw9qkF9A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NADRZpm7FFr3rE68hwiQNQuQhIlEOm5s16CROmBP2ATCiQ/0wQDL8y6wLQsgQ2X2s SVJgPYgrGF1bbDTIIRlSXkMjkTMLm4sIi/Hy+mKQH1ow/j0UtkvS/K7HuEL0MaJrQj gDAUlDKD0vIY2NtsXY4ER863VxxBL4JqVE1BEwzD351g2l1MXdihy6eVgsDBGiObM6 zYOkHamkofLWRQOA9ULozMRmhasE8+GM/W4hXOCBR4UywlAr3DwN7BtsB7EUXhwF9K 1n5p7/JiGLChrckIXXOtAXJ2Q2loK4SYkz/9POOngy3tdZRALyq0ESR5WQ+kWMob+A 8YIqSwlaPekMg== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0E5491208FE; Fri, 23 Sep 2022 18:01:06 -0400 (EDT) In-Reply-To: (kobarity@gmail.com's message of "Mon, 19 Sep 2022 15:31:56 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243501 Archived-At: > 1. emacs -Q > 2. Open the following C mode file. > > #+begin_src C > int > main() { > sub(); > } > > int > sub() { > printf("sub\n"); > } > #+end_src > > 3. M-x hs-minor-mode > 4. Move the point to the "printf" line in the "sub" function. > 5. Shift mouse-2 in the function "main". > The function body of "sub" is hidden instead of "main". This is > not I expected. Hmm... indeed it's a trivial oversight in my patch, sorry. The patch below should fix it. > (posn-set-point (event-end e)) was added to `hs-toggle-hiding' by this > commit. This is the main cause of bug#52092. Indeed, thanks. I had no idea that (posn-point (posn-at-point POS)) doesn't return POS if POS is within an invisible chunk of text and instead returns the next visible position. I'll have to think about how best to fix the consequence. Stefan diff --git a/lisp/progmodes/hideshow.el b/lisp/progmodes/hideshow.el index c0796fc2eeb..8dd8c7e182c 100644 --- a/lisp/progmodes/hideshow.el +++ b/lisp/progmodes/hideshow.el @@ -948,7 +948,7 @@ hs-toggle-hiding "Toggle hiding/showing of a block. See `hs-hide-block' and `hs-show-block'. Argument E should be the event that triggered this action." - (interactive) + (interactive (list last-nonmenu-event)) (hs-life-goes-on (posn-set-point (event-end e)) (if (hs-already-hidden-p)