From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Date: Sat, 05 Aug 2023 18:58:00 -0400 Message-ID: References: <8B08E514-B2D5-48F5-BA90-4F5A9492F8F9@gmail.com> <83r0oivr7v.fsf@gnu.org> <83jzuavnm2.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31082"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Mackenzie , mattias.engdegard@gmail.com, 65017@debbugs.gnu.org, eric.marsden@risk-engineering.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 06 00:59:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSQEv-0007te-3E for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Aug 2023 00:59:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSQEk-00026u-0g; Sat, 05 Aug 2023 18:59:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSQEg-00020X-G5 for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 18:59:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSQEg-0004kf-7P for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 18:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSQEf-0001hz-T6 for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 18:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 22:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65017 X-GNU-PR-Package: emacs Original-Received: via spool by 65017-submit@debbugs.gnu.org id=B65017.16912763046518 (code B ref 65017); Sat, 05 Aug 2023 22:59:01 +0000 Original-Received: (at 65017) by debbugs.gnu.org; 5 Aug 2023 22:58:24 +0000 Original-Received: from localhost ([127.0.0.1]:58328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSQE3-0001h1-Pc for submit@debbugs.gnu.org; Sat, 05 Aug 2023 18:58:24 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSQE1-0001gp-Cc for 65017@debbugs.gnu.org; Sat, 05 Aug 2023 18:58:21 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 20B9F1000EF; Sat, 5 Aug 2023 18:58:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1691276294; bh=K3Wia532RHU0R38VpeV5yFKSs/UpIf47KHAgZ674sDE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BYx/J5v9fNAXynKYszCUbwS5ESsmd/R3K7TeVgNe1/VoJCfxym52rQz7ZvkmFXAIR S4wJr9vUUO/McUSgIxUQoF4k+yTj5ejDGD7OwzggLP2Vbfa+kRJTvFQSzLSOR/sauN goiZXeBjG3NTlIbzg2cKaYrrawvVBREpf6YPerxaXfclr/n8luR5StGM0CdyXi39hx 0XtCizLZw/sMQsJDQ9H1GhJ1wfUiWhJ3qyae98Bp1j3D2UKMD6+CXBRbbxlv8giV/8 HYAbJcIqI6EJhgICp0ueXSI9QVsqVfVDx+y1ck8EdmGL3ipm8M3+dr9wYV/TPGEgGi Rd4bpEIuVdwew== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E2FC91000AD; Sat, 5 Aug 2023 18:58:14 -0400 (EDT) Original-Received: from alfajor (unknown [190.16.213.142]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 611E712032C; Sat, 5 Aug 2023 18:58:13 -0400 (EDT) In-Reply-To: <83jzuavnm2.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Aug 2023 18:22:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266824 Archived-At: >> internal-macroexpand-for-load isn't being called in the context of a >> byte compilation. It might create a symbol with position which wrongly >> matches, or fails to match, another symbol. This is what has happened >> in this bug. > > If internal-macroexpand-for-load is "verboten" from being called by > the byte-compiler, I'd expect an assertion in it to that effect. It's not "verboten". Removing the binding just says that if you want to pass adorned code to that function, it's the caller's responsability to let-bind the variable around the call. > Because someone, some day, might easily forget and call that function > in the byte-compiler. The byte-compiler already let-binds that variables, so it won't be a problem. > Btw, why was this binding added there to begin with? IIUC it took some trial and error to get to understand where that var needs to be bound (as well as where is the right spot to strip the sympos), and this is just one binding that was never removed after we found a better place for it. Stefan