From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gabriele@medialab.sissa.it, 67124@debbugs.gnu.org
Subject: bug#67124: 26.3; query-replace Arg out of range with comma option (at end-buffer)
Date: Thu, 16 Nov 2023 13:01:27 -0500 [thread overview]
Message-ID: <jwvv8a1k2bd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83jzqhprhb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Nov 2023 18:56:00 +0200")
>> > What are you trying to understand?
>>
>> Why you're saying that in
>>
>> ;; `replace-match' leaves point at the end of the replacement text,
>> ;; so move point to the beginning when replacing backward.
>> (when backward (goto-char (nth 0 match-data)))
>>
>> it is not true that
>>
>> and (nth 0 match-data) == (match-beginning 0), no?
>
> Because of markers vs positions, as I've tried to explain. The
> difference is minor, of course.
But `goto-char` doesn't care about that difference, and no buffer will
be changed between the time we call `match-data` (thus creating the
markers) and the time we use those markers, so going through markers is
just extra work for no benefit.
IOW, I still don't understand how "markers vs positions" is relevant in
(when backward (goto-char (nth 0 match-data)))
>> > What my kludge did is simply use a marker, so the adjusted position is
>> > not clobbered.
>>
>> I don't see that. E.g. if you change your code from
>>
>> (set-match-data (list (car match-data) (nth 1 (match-data))))
>> to
>> (set-match-data (list (car match-data) (nth 1 (match-data t))))
>>
>> it fixes the problem just as well, AFAICT.
>
> Yes, but match-data (the function) returns updated positions, which
> behave like markers across the replace-match call.
But the positions have already been updated. So
(match-data t)
would also return those updated positions, even though it doesn't
use markers.
Stefan
next prev parent reply other threads:[~2023-11-16 18:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 19:40 bug#67124: 26.3; query-replace Arg out of range with comma option (at end-buffer) Gabriele Nicolardi
2023-11-12 9:48 ` Eli Zaretskii
2023-11-13 3:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-13 14:17 ` Eli Zaretskii
2023-11-16 14:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 14:55 ` Eli Zaretskii
2023-11-16 16:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 16:56 ` Eli Zaretskii
2023-11-16 18:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-11-16 18:34 ` Eli Zaretskii
2023-11-16 15:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 16:51 ` Eli Zaretskii
2023-11-16 18:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-18 10:18 ` Eli Zaretskii
2023-11-18 16:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-18 21:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <ed11baa2-cf89-4a72-91d0-8f26c0af4126@medialab.sissa.it>
2023-11-13 14:06 ` Eli Zaretskii
2023-11-13 14:21 ` Dmitry Gutov
2023-11-13 14:38 ` Eli Zaretskii
2023-11-13 14:45 ` Dmitry Gutov
2023-11-13 15:39 ` Gabriele Nicolardi
2023-11-16 14:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 16:27 ` Gabriele Nicolardi
2023-11-15 13:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvv8a1k2bd.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=67124@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gabriele@medialab.sissa.it \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.